#42313 closed enhancement (fixed)
Introduce an X-Redirect-By header
| Reported by: | joostdevalk | Owned by: | SergeyBiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.1 |
| Component: | Canonical | Version: | |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: |
Description
Diagnosing redirect loops can often be very confusing because many parts of a system can perform a redirect. The introduction of the X-Redirect-By header would allow the application to be identified more easily.
Yoast SEO already sends this header and we've found it to be very useful many a time, at nearly no overhead.
Attachments (5)
Change History (23)
#4
@
8 years ago
- Keywords has-patch removed
- Resolution fixed
- Status closed → reopened
I really like the idea of this header, but I think we can make the implementation even better.
If the header value could be passed as a parameter in addition to via a filter, it would save the need to call add_filter() immediately before calling the redirect function.
Thoughts?
#5
@
8 years ago
Since the $status can be passed as a parameter and then modified by a filter, it makes sense that $x_redirect_by should be treated the same way.
#7
@
8 years ago
- Keywords needs-patch added; dev-feedback removed
- Resolution fixed
- Status closed → reopened
The parameter needs adding to wp_safe_redirect() too.
#9
@
8 years ago
- Milestone 5.0 → 5.0.1
- Resolution fixed
- Status closed → reopened
@since needs updating
#13
@
8 years ago
- Keywords needs-refresh added
Hi,
5.0.3 is going to be released in a couple of weeks. We are currently sorting the remaining tickets in the milestone. The ticket is sorted in milestone 5.0.3, but requires @since and a commit/backport to the associated branch. That would be great to have a quick refresh.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Patch