WordPress.org

Make WordPress Core

#42314 closed defect (bug) (duplicate)

Customizer hangs on the "downloading" full overlay when closing the FTP credentials modal

Reported by: afercia Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.9
Component: Customize Keywords: has-screenshots needs-patch
Focuses: ui Cc:

Description

Splitting this out from https://core.trac.wordpress.org/ticket/42205#comment:11

  • force the FTP modal to appear as described in #42205
  • apply the patches from #42205 and #42184 if not merged yet
  • go to the Customizer > change theme > wp.org themes
  • click on theme details to open the details modal and then install
  • or click directly on Install & Preview
  • the FTP modal opens correctly

However, when closing the modal (press "Cancel") the Customizer hangs on the "downloading" full overlay, see screenshot below. There's no escape from there, the only chance is refresh or browser's Back button:

https://cldup.com/lOuhciR29P.png

Change History (2)

#1 @westonruter
19 months ago

In addition to dismissing the notification on request.fail() we also need to dismiss when the credentials are requested. This is the code that would need to be updated: https://github.com/WordPress/wordpress-develop/blob/a719234/src/wp-admin/js/customize-controls.js#L3167-L3179

#2 @celloexpressions
19 months ago

  • Milestone 4.9 deleted
  • Resolution set to duplicate
  • Status changed from new to closed

This is the primary thing that #42184 addresses (per the ticket description) and is fixed in yesterday's patch there.

Note: See TracTickets for help on using tickets.