![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Changes between Initial Version and Version 1 of Ticket #42321, comment 5
- Timestamp:
- 10/25/2017 01:08:55 PM (9 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #42321, comment 5
initial v1 9 9 3. There are some coding standard issues in the patch. Have a read of https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/#spacing . 10 10 11 4. It's a small thing but `menuName = $( document.getElementById( 'menu-name' ) )` is more performant than `menuName = $( '#menu-name' )`-11 4. It's a small thing but `menuName = $( document.getElementById( 'menu-name' ) )` is more performant than `menuName = $( '#menu-name' )`- 12 12 https://jsperf.com/wrap-an-element-or-html-collection-in-jquery 13 13
