WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#42355 closed defect (bug) (fixed)

Missing plural forms in "unexpected output" string

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: pento's profile pento
Milestone: 5.1 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

This message can be displayed when activating a plugin:

The plugin generated %d characters of <strong>unexpected output</strong> during activation. If you notice &#8220;headers already sent&#8221; messages, problems with syndication feeds or other issues, try deactivating or removing this plugin.

For proper i18n, the first sentence should use _n().

Attachments (1)

42355.diff​ (1.5 KB) - added by jamosova 6 years ago.

Download all attachments as: .zip

Change History (6)

#1 @jamosova
6 years ago

Working on it now.

@jamosova
6 years ago

#2 @jamosova
6 years ago

  • Keywords has-patch added

Fixed in 42355.diff.

Tested to confirm that it works. See screenshots below:

1 character:

​https://cldup.com/Tksa-ZPfci.png

2 characters:

​https://cldup.com/L0Rds82r1a.png

#3 @pento
6 years ago

  • Milestone changed from Awaiting Review to 5.0
  • Owner set to pento
  • Status changed from new to assigned

#4 @pento
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 43667:

Plugins: Pluralise the "unexpected output during activation" message.

When a plugin is activated, it can trigger a warning message if it outputs data at that time. This error message was being run through __(), instead of _n(), so it wasn't possible to correctly pluralise the message.

Props jamosova.
Fixes #42355.

#5 @johnbillion
6 years ago

  • Milestone changed from 5.0 to 5.1
Note: See TracTickets for help on using tickets.