Context Navigation

← Previous Ticket
Next Ticket →

#42355 closed defect (bug) (fixed)

Missing plural forms in "unexpected output" string

Reported by:	SergeyBiryukov	Owned by:	pento
Priority:	normal	Milestone:	5.1
Component:	I18N	Version:
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:

Description

This message can be displayed when activating a plugin:

The plugin generated %d characters of <strong>unexpected output</strong> during activation. If you notice “headers already sent” messages, problems with syndication feeds or other issues, try deactivating or removing this plugin.

For proper i18n, the first sentence should use _n().

Attachments (1)

42355.diff (1.5 KB ) - added by jamosova 8 years ago.

Download all attachments as: .zip

Change History (6)

#1 @jamosova
8 years ago

Working on it now.

@jamosova
8 years ago

Attachment 42355.diff added

#2 @jamosova
8 years ago

Keywords has-patch added

Fixed in 42355.diff.

Tested to confirm that it works. See screenshots below:

1 character:

https://cldup.com/Tksa-ZPfci.png

2 characters:

https://cldup.com/L0Rds82r1a.png

#3 @pento
8 years ago

Milestone Awaiting Review → 5.0
Owner set to pento
Status new → assigned

#4 @pento
8 years ago

Resolution → fixed
Status assigned → closed

In 43667:

Plugins: Pluralise the "unexpected output during activation" message.

When a plugin is activated, it can trigger a warning message if it outputs data at that time. This error message was being run through __(), instead of _n(), so it wasn't possible to correctly pluralise the message.

Props jamosova.
Fixes #42355.

#5 @johnbillion
8 years ago

Milestone 5.0 → 5.1

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#42355 closed defect (bug) (fixed)

Missing plural forms in "unexpected output" string

Description

Attachments (1)

Change History (6)

#1 @jamosova 8 years ago

@jamosova 8 years ago

#2 @jamosova 8 years ago

#3 @pento 8 years ago

#4 @pento 8 years ago

#5 @johnbillion 8 years ago