Make WordPress Core

Opened 7 years ago

Closed 8 weeks ago

#42358 closed defect (bug) (wontfix)

Twenty Seventeen: Social Links menu items in footer get hidden when used as child

Reported by: subrataemfluence's profile subrataemfluence Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.9
Component: Bundled Theme Keywords: has-screenshots dev-feedback 2nd-opinion close
Focuses: ui Cc:

Description

Inside customizer if I reorder Social Menu Items as Children while they are on footer, child items are not visible any more and no way to access them! But they come up as dropdown sub menu item(s) when placed in Top menu. Screenshot attached.

I think when Footer menu is checked menu option to create a parent-child kind of ordering should not be available. However, if both options (Header and Footer) are checked, parent-child ordering needs to be there, but it should only in header menu only and leaving all footer menu items visible.

Attachments (1)

image.jpg (32.6 KB) - added by subrataemfluence 7 years ago.

Download all attachments as: .zip

Change History (5)

#1 @rinkuyadav999
7 years ago

  • Component changed from Menus to Bundled Theme
  • Keywords has-screenshots dev-feedback added

#2 @sabernhardt
3 years ago

  • Keywords 2nd-opinion added

Twenty Seventeen uses the $depth argument of 1 in wp_nav_menu for the Social Links Menu location. It only shows the top level so those links stay in one inline list. The same argument is used for social/secondary menu locations in each bundled theme from Twenty Fifteen to Twenty Twenty-One.

If this is changed in (future) themes, it might require a new walker function.

On the other hand, if someone accidentally puts a link at another level, some notification could help. The Menus screen and Customizer would need to check the depth argument and either show an error message or even try to correct it.

#3 @karmatosed
2 months ago

  • Keywords close added

I am reluctant to change this as a number of themes have the issue. That doesn't mean we shouldn't have a different solution, but perhaps that is to look in the future at using the navigation block. I am reluctant to explore today a solution that involved checking the depth argument and showing error messages. That said, this is my opinion so I am going to add the keyword 'close' and get other opinions before doing that.

#4 @karmatosed
8 weeks ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

As this has sat with a recommendation to close for a little while I am now going to progress this. Thank you everyone for your collaboration.

Note: See TracTickets for help on using tickets.