WordPress.org

Make WordPress Core

Opened 22 months ago

Last modified 5 months ago

#42364 new task (blessed)

Customize: Remove deprecated nav menu classes

Reported by: westonruter Owned by:
Milestone: Future Release Priority: low
Severity: normal Version: 4.9
Component: Customize Keywords: early has-patch needs-refresh
Focuses: Cc:

Description

The following classes are deprecated in 4.9 and can be removed in 5.0:

  • wp.customize.Menus.NewMenuControl (in JS)
  • WP_Customize_New_Menu_Section (in PHP)
  • WP_Customize_New_Menu_Control (in PHP)

These classes are not used by plugins and they are not used in core. For more, see #42357.

Attachments (1)

42364.diff (8.5 KB) - added by Matthias Reuter 16 months ago.
I've created a diff with the patch to remove the classes mentioned.

Download all attachments as: .zip

Change History (9)

#1 @westonruter
22 months ago

In 42034:

Customize: Deprecate nav menu classes that are no longer used, instead of removing them immediately.

  • Deprecate PHP classes WP_Customize_New_Menu_Section and WP_Customize_New_Menu_Control.
  • Deprecate JS class wp.customize.Menus.NewMenuControl.
  • Also introduce wp.customize.Menus.createNavMenu() for logic to create nav menus separately from the logic for handling UI interactions.

Amends [41768].
See #40104, #42364.
Fixes #42357.

@Matthias Reuter
16 months ago

I've created a diff with the patch to remove the classes mentioned.

#2 @Matthias Reuter
16 months ago

  • Keywords has-patch added; needs-patch removed

#3 @pento
10 months ago

  • Milestone changed from 5.0 to 5.1

This ticket was mentioned in Slack in #core-customize by dlh. View the logs.


10 months ago

#5 @desrosj
7 months ago

@Matthias Reuter are you able to refresh the patch? It is not applying to trunk currently.

#6 @desrosj
7 months ago

Sorry, incorrect tag above. @matthias-reuter.

#7 @pento
7 months ago

  • Keywords needs-refresh added
  • Milestone changed from 5.1 to 5.2

#8 @jorbin
5 months ago

  • Milestone changed from 5.2 to Future Release

As 5.2 is now in beta and this was something that needed early attention, I'm removing it from the milestone.

Note: See TracTickets for help on using tickets.