WordPress.org
Get WordPress

Make WordPress Core

Opened 17 years ago

Closed 17 years ago

Last modified 17 years ago

#4237 closed task (blessed) (fixed)

Convert to using wp_parse_args()

Reported by: rob1n's profile rob1n Owned by: rob1n's profile rob1n
Milestone: 2.3 Priority: normal
Severity: normal Version:
Component: General Keywords:
Focuses: Cc:

Description


Attachments (1)

4237-wpincludes.diff​ (16.8 KB) - added by rob1n 17 years ago.

Download all attachments as: .zip

Change History (8)

#1 @rob1n
17 years ago

  • Owner changed from anonymous to rob1n
  • Status changed from new to assigned

#2 @ryan
17 years ago

While we're at it, change wp_parse_args() so that it doesn't eliminate args that aren't in defaults. Plugins need to pass things along.

#3 @rob1n
17 years ago

Yep, makes sense.

#4 @rob1n
17 years ago

(In [5428]) Don't discard non-default args in wp_parse_args(). see #4237

@rob1n
17 years ago

#5 @rob1n
17 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [5444]) Use wp_parse_args(). fixes #4237

#6 @mdawaffe
17 years ago

FYI, [5428] implies that wp_parse_args() followed by an extract() cannot be trusted if given user imput.

#7 @ryan
17 years ago

We should probably be using the EXTR_SKIP argument to extract everywhere.

Note: See TracTickets for help on using tickets.