Make WordPress Core

Opened 7 months ago

Closed 7 months ago

Last modified 7 months ago

#42371 closed defect (bug) (invalid)

Twenty Seventeen: Remove deprecated tags from stylesheet

Reported by: rinkuyadav999 Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.9
Component: Bundled Theme Keywords: has-patch dev-feedback
Focuses: Cc:


twentyseventeen removing deprecated tags from style.css Also there are other core themes having deprecated tags.

Attachments (2)

42371.patch (1.0 KB) - added by rinkuyadav999 7 months ago.
valid-tags-4.9.png (15.0 KB) - added by rinkuyadav999 7 months ago.
Theme tags for 4.9

Download all attachments as: .zip

Change History (8)

#1 @rinkuyadav999
7 months ago

  • Keywords has-patch dev-feedback added

#2 @Presskopp
7 months ago

  • Summary changed from Remove deprecated tags from stylesheet to Twenty Seventeen: Remove deprecated tags from stylesheet

This ticket was mentioned in Slack in #themereview by davidakennedy. View the logs.

7 months ago

#4 @davidakennedy
7 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

Hi @rinkuyadav999, thanks for creating this ticket.

Unless I'm mistaken, you've removed these tags:

flexible-header custom-menu rtl-language-support threaded-comments translation-ready

All of those are still valid tags though. See: https://make.wordpress.org/themes/handbook/review/required/theme-tags/

Double checking all of Twenty Seventeen's tags, I don't see any tags that aren't valid.

I'm going to close this ticket, but let me know if I missed anything here.

I'll also double check other default themes for outdated tags. Thanks!

#5 @rinkuyadav999
7 months ago

Hi @davidakennedy

https://make.wordpress.org/themes/handbook/review/required/theme-tags/ is not for 4.9.

See all valid tags of 4.9 in screenshot.

7 months ago

Theme tags for 4.9

#6 @celloexpressions
7 months ago

@rinkuyadav999 those are the tags that are visually displayed to users as features, which is now only a subset of all of the tags available for themes. The valid theme tags for WordPress.org have not changed for 4.9 but may change in the future.

Note: See TracTickets for help on using tickets.