WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#4239 closed defect (bug) (fixed)

PREG_BACKTRACK_LIMIT_ERROR encountered during WP import

Reported by: ryan Owned by: ryan
Milestone: 2.2 Priority: normal
Severity: normal Version: 2.2
Component: Administration Keywords: wxr importer preg
Focuses: Cc:

Description

The WordPress importer uses preg_match_all to slurp items from the import file. Large items can cause a PREG_BACKTRACK_LIMIT_ERROR. This can be avoided by bumping pcre.backtrack_limit, but that isn't very friendly. Instead, the importer shouldn't use preg_match_all. There are other ways of retrieving the items.

http://us2.php.net/manual/en/ref.pcre.php#pcre.constants
http://us2.php.net/manual/en/ref.pcre.php#ini.pcre.backtrack-limit

Attachments (1)

no_pref.diff (1.7 KB) - added by ryan 7 years ago.

Download all attachments as: .zip

Change History (6)

ryan7 years ago

comment:1 matt7 years ago

omgbbqphp.

comment:3 ryan7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5422]) Don't preg_match_all when processing items. fixes #4239 for 2.2

comment:4 ryan7 years ago

(In [5423]) Don't preg_match_all when processing items. fixes #4239 for 2.3

comment:5 ryan7 years ago

Testing went well, so I committed for 2.2 since this bug sucks for those affected.

Note: See TracTickets for help on using tickets.