WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#42392 closed defect (bug) (fixed)

Customize: Changeset scheduled month gets unselected if less than 10

Reported by: westonruter Owned by: westonruter
Priority: normal Milestone: 4.9
Component: Customize Version: 4.9
Severity: normal Keywords: has-patch has-screenshots dev-reviewed
Cc: Focuses:

Description (last modified by westonruter)

Steps to reproduce:

  1. Select changeset month for January of 2018.
  2. Save changeset.
  3. Reload the Customizer.
  4. Open the Publish Settings and notice the month dropdown is blank instead of 1-Jan.

Regression introduced in #42373.

Attachments (3)

42392.0.diff​ (1.6 KB ) - added by westonruter 9 years ago.
​https://github.com/xwp/wordpress-develop/pull/297
before.png​ (87.1 KB ) - added by westonruter 9 years ago.
after.png​ (101.8 KB ) - added by westonruter 9 years ago.

Download all attachments as: .zip

Change History (12)

@westonruter
9 years ago

​https://github.com/xwp/wordpress-develop/pull/297

#1 @westonruter
9 years ago

  • Keywords has-patch dev-feedback needs-testing added

#2 @westonruter
9 years ago

  • Description modified (diff)

#3 @westonruter
9 years ago

  • Owner set to westonruter
  • Status new → accepted

#4 @dlh
9 years ago

I was able to replicate the bug using the given steps, and the patch addresses it with no side-effects I've seen thus far.

@westonruter
9 years ago

@westonruter
9 years ago

#5 @westonruter
9 years ago

  • Keywords has-screenshots added; needs-testing removed

This ticket was mentioned in ​Slack in #core by westonruter. ​View the logs.
9 years ago

#7 @joemcgill
9 years ago

  • Keywords dev-reviewed added; dev-feedback removed

Tested 42392.0.diff​ and confirmed that it fixes the issue. The patch looks fine to me.

This ticket was mentioned in ​Slack in #core-committers by joemcgill. ​View the logs.
9 years ago

#9 @westonruter
9 years ago

  • Resolution → fixed
  • Status accepted → closed

In 42104:

Customize: Strip zero padding when setting month to prevent de-selection; add zero-padding for number input fields when blurring.

Amends [42042].
See #42373.
Fixes #42392.

Note: See TracTickets for help on using tickets.