Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #42395, comment 1


Ignore:
Timestamp:
11/01/2017 08:58:19 PM (4 years ago)
Author:
westonruter
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #42395, comment 1

    initial v1  
    11@dlh I have an initial patch which seems to fix the issue. See [attachment:42395.0.wip.diff]. But it's not pretty. I'd appreciate your insights.
     2
     3I'm not satisfied with the patch I have, as it is hacky and exposes some underlying problems with how we implemented settings for nav menus and nav menu items. In particular, we're including dynamic “generated” properties like `original_title` and `type_label` in the changeset value. These should be omitted and only dynamically added when the via the filter `wp_setup_nav_menu_item`, for example.