Typechecker problem in wp-db.php

[mkomar]

Argument 3 to hash_hmac() must be of type ?string, int given in /xxx/wp-includes/wp-db.php on line 1969

[mkomar]

patch to resolve the problem.

[pento]

Thanks for the patch, @mkomar! Looks good to me, can another committer sign off, please?

Milestoning this for 4.9, it will also need to be back ported back to 3.7.

[peterwilsoncc]

Checked with patch applied.

• db tests still pass
• tested with the following in wp shell

vagrant@vvv:~/www/wordpress-develop/public_html$ wp shell
wp> echo esc_sql( 'my_%s_is_here' )
my_{1ee1e59bb60fe439935c62feaddc27663f7f4c28c259b77396a66862bf7ce08b}s_is_here
wp> exit
vagrant@vvv:~/www/wordpress-develop/public_html$ wp shell
wp> echo esc_sql( 'my_%s_is_here' )
my_{ef1631a8a1c700ba5a1eb3f7e60974329c42910a031432de15ab4ab1378ef1af}s_is_here
wp> exit

[peterwilsoncc]

For clarity: above was with AUTH_SALT undefined.

[pento]

In 42119:

WPDB: Fix a PHP notice when AUTH_SALT is undefined.

In wpdb::placeholder_escape(), the key for hash_hmac() falls back to rand() when AUTH_SALT is undefined. hash_hmac() requires the key to be a string, however, so we need to cast it as such.

Props mkomar.
Fixes #42401.

[pento]

Re-opening for backporting to the 3.7-4.8 branches.

[dd32]

In 42230:

WPDB: Check that AUTH_SALT is not empty, Fix a PHP notice when AUTH_SALT is undefined.

Props jsonfry, mkomar, pento.
Merges [42119] and [42120] to the 4.8 branch.
Fixes #42431 and #42401 for 4.8.

[dd32]

In 42231:

WPDB: Check that AUTH_SALT is not empty, Fix a PHP notice when AUTH_SALT is undefined.

Props jsonfry, mkomar, pento.
Merges [42119] and [42120] to the 4.7 branch.
Fixes #42431 and #42401 for 4.7.

[dd32]

In 42232:

WPDB: Check that AUTH_SALT is not empty, Fix a PHP notice when AUTH_SALT is undefined.

Props jsonfry, mkomar, pento.
Merges [42119] and [42120] to the 4.6 branch.
Fixes #42431 and #42401 for 4.6.

[dd32]

In 42233:

WPDB: Check that AUTH_SALT is not empty, Fix a PHP notice when AUTH_SALT is undefined.

Props jsonfry, mkomar, pento.
Merges [42119] and [42120] to the 4.5 branch.
Fixes #42431 and #42401 for 4.5.

[dd32]

In 42234:

WPDB: Check that AUTH_SALT is not empty, Fix a PHP notice when AUTH_SALT is undefined.

Props jsonfry, mkomar, pento.
Merges [42119] and [42120] to the 4.4 branch.
Fixes #42431 and #42401 for 4.4.

[dd32]

In 42235:

WPDB: Check that AUTH_SALT is not empty, Fix a PHP notice when AUTH_SALT is undefined.

Props jsonfry, mkomar, pento.
Merges [42119] and [42120] to the 4.3 branch.
Fixes #42431 and #42401 for 4.3.

[dd32]

In 42236:

WPDB: Check that AUTH_SALT is not empty, Fix a PHP notice when AUTH_SALT is undefined.

Props jsonfry, mkomar, pento.
Merges [42119] and [42120] to the 4.2 branch.
Fixes #42431 and #42401 for 4.2.

[dd32]

In 42237:

WPDB: Check that AUTH_SALT is not empty, Fix a PHP notice when AUTH_SALT is undefined.

Props jsonfry, mkomar, pento.
Merges [42119] and [42120] to the 4.1 branch.
Fixes #42431 and #42401 for 4.1.

[dd32]

In 42238:

WPDB: Check that AUTH_SALT is not empty, Fix a PHP notice when AUTH_SALT is undefined.

Props jsonfry, mkomar, pento.
Merges [42119] and [42120] to the 4.0 branch.
Fixes #42431 and #42401 for 4.0.

[dd32]

In 42239:

WPDB: Check that AUTH_SALT is not empty, Fix a PHP notice when AUTH_SALT is undefined.

Props jsonfry, mkomar, pento.
Merges [42119] and [42120] to the 3.9 branch.
Fixes #42431 and #42401 for 3.9.

[dd32]

In 42240:

WPDB: Check that AUTH_SALT is not empty, Fix a PHP notice when AUTH_SALT is undefined.

Props jsonfry, mkomar, pento.
Merges [42119] and [42120] to the 3.8 branch.
Fixes #42431 and #42401 for 3.8.

[dd32]

In 42241:

WPDB: Check that AUTH_SALT is not empty, Fix a PHP notice when AUTH_SALT is undefined.

Props jsonfry, mkomar, pento.
Merges [42119] and [42120] to the 3.7 branch.
Fixes #42431 and #42401 for 3.7.