#42402 closed defect (bug) (fixed)
When viewing a revision with show_split_view set to false, the title is still shown in two columns
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.1 | Priority: | low |
Severity: | normal | Version: | 3.6 |
Component: | Revisions | Keywords: | good-first-bug has-patch needs-testing |
Focuses: | administration | Cc: |
Description
The revision_text_diff_options
filter can be used to set the show_split_view
argument to false
, which means when viewing the revisions screen for a post the differences will be shown inline instead of in two columns.
add_filter( 'revision_text_diff_options', function( array $args ) {
$args['show_split_view'] = false;
return $args;
} );
When this is the case, the Title field is still shown in two columns instead of one if the title has not been changed. If the title has been changed, it correctly appears in one column.
Attachments (2)
Change History (10)
#2
@
7 years ago
- Keywords reporter-feedback removed
@adamsilverstein Thanks for testing. The Title field is shown in two columns instead of one if the title has not been changed. If the title has been changed, it correctly appears in one column.
#3
@
7 years ago
@johnbillion Ah! I missed that important detail from your bug report. Thanks.
I see you marked this as a good first bug so I'll leave it for now to see if a new contributor wants to lend a hand. A head start: the title is output a little differently than the remainder of the fields, see wp-admin/includes/revisions.php:L103
. ps. my RevisionsPlus plugin enables the single column view among other things: https://github.com/adamsilverstein/RevisionsPlus
#4
@
7 years ago
- Keywords has-patch added; needs-patch removed
Hey guys, thanks for the detailed ticket! I've added a check for show_split_view
and if it's set to true, show the title in two columns otherwise just show it in a new row.
btw this patch was sent during the contribution day after WordCamp Sofia 2017
#6
@
7 years ago
- Keywords needs-testing added
- Milestone changed from Awaiting Review to 5.0
- Owner set to adamsilverstein
- Status changed from new to assigned
- Version set to 3.6
In: 42402.2.diff
- refresh against trunk
- only show title twice if it has changed in single column view.
@mbelchev could you give this patch a test?
screencast: https://cl.ly/3j1i0b1c2b3g
@johnbillion Thanks for the bug report. I tested this out and I see the title in a single column. Can you confirm this is the behaviour with all plugins disabled and a default theme active?