#42406 closed defect (bug) (fixed)
Customize: Can't switch back to active theme once changeset is saved
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.9 | Priority: | normal |
Severity: | normal | Version: | 4.9 |
Component: | Customize | Keywords: | has-patch commit dev-reviewed |
Focuses: | Cc: |
Description
Steps to demonstrate:
- Open the Customizer, make a change, and save your changeset as a draft.
- Open the Themes panel, discover that you can't preview themes while the changeset is a draft, and switch the changeset status back to "publish."
- Go back to the Themes panel, discover that you now can preview themes again, and preview a new theme.
- Decide you don't like the new theme, and go back to the Themes panel to preview another theme or go back to the active theme.
- Get the "Sorry, you can’t preview new themes..." error.
Attachments (5)
Change History (21)
#1
@
7 years ago
- Keywords has-patch needs-testing added
- Milestone changed from Awaiting Review to 4.9
This ticket was mentioned in Slack in #core-customize by dlh. View the logs.
7 years ago
#3
@
7 years ago
The patch fixes the issue as described, but I found that the themes panel was still inaccessible after publishing the changeset. In 42406.diff I've added a binding for toggleDisabledNotifications()
on the changesetStatus
state to try to address that.
#4
@
7 years ago
@dlh I found there were some additional problems where even though I had saved draft and I saw the notice, I could still click on the Live Preview buttons. This was due to the logic for determining the theme switch availability not being copied out to each place where it was needed. So 42406.3.diff factors out the logic into a common canSwitchTheme
method to be re-used in each instance.
This ticket was mentioned in Slack in #core-customize by westonruter. View the logs.
7 years ago
#7
@
7 years ago
42406.3.diff works as expected with respect to the original issue. I did notice that if you're unable to switch themes, but you click "Theme Details" and then use the next/previous buttons to browse themes, the "Live Preview" button becomes clickable, although it doesn't actually do anything.
#8
@
7 years ago
@dlh Good catch. 42406.5.diff (delta) moves the logic for disabling the buttons to the showDetails
method itself, so the buttons will be disabled regardless of how the user gets to the details overlay. Does that wrap things up?
This ticket was mentioned in Slack in #core by jeffpaul. View the logs.
7 years ago
This ticket was mentioned in Slack in #core-committers by westonruter. View the logs.
7 years ago
#14
@
7 years ago
- Keywords commit dev-reviewed added; dev-feedback removed
42406.5.diff LGTM as well
@dlh The part in your steps is 2:
Note in particular that if you had hit the Publish button, then it would have worked as expected. The issue is that you switched the status but then didn't action on the status change. So I think it's just a matter of it neglecting to look at the saved
changesetStatus
when currently is looking just atselectedChangesetStatus
. It needs to account for both.Let me know if 42406.0.diff fixes that issue for you.