![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 9 years ago
Closed 9 years ago
#42415 closed defect (bug) (fixed)
Customize: changeset_uuid does not get stripped from URL after activating theme
| Reported by: | westonruter | Owned by: | westonruter |
|---|---|---|---|
| Priority: | low | Milestone: | 4.9 |
| Component: | Customize | Version: | 4.9 |
| Severity: | normal | Keywords: | has-patch commit dev-reviewed |
| Cc: | Focuses: |
Description
Steps to reproduce:
- Open customizer.
- Switch to a different theme.
- Notice that the
changeset_uuidquery parameter is in the URL. - Hit “Activate & Publish”
- Notice the
changeset_uuidquery parameter is still in the URL. - Reload the page and see an error about the changeset already being published.
The changeset_uuid needs to be stripped from the URL regardless of whether or not branching mode is enabled upon publishing because a published changeset cannot be further edited.
Attachments (3)
Change History (12)
This ticket was mentioned in Slack in #core by jeffpaul. View the logs.
9 years ago
This ticket was mentioned in Slack in #core-customize by westonruter. View the logs.
9 years ago
This ticket was mentioned in Slack in #core-customize by bpayton. View the logs.
9 years ago
Note:
See TracTickets
for help on using tickets.
It took me a moment to process the if/else, and I'm wondering whether the following would be clearer:
populateChangesetUuidParam( api.settings.changeset.branching && shouldInclude )