WordPress.org

Make WordPress Core

Opened 7 months ago

Closed 7 months ago

#42424 closed defect (bug) (fixed)

Codemirror: Unify line endings in csslint.js

Reported by: obenland Owned by: obenland
Milestone: 4.9 Priority: normal
Severity: normal Version: 4.9
Component: Customize Keywords: has-patch dev-reviewed commit
Focuses: Cc:

Description

The csslint.js file comes with severe line ending and possibly whitespace issues, to a degree where it makes the file basically unmergeable in larger WordPress installations.

This is likely a problem caused upstream and will probably be a non-issue once #41870 is merged in the next release.

Attachments (1)

42424.diff (240.6 KB) - added by obenland 7 months ago.

Download all attachments as: .zip

Change History (4)

@obenland
7 months ago

#1 @westonruter
7 months ago

  • Keywords dev-feedback added
  • Owner set to westonruter
  • Status changed from new to accepted

#2 @westonruter
7 months ago

  • Keywords dev-reviewed commit added; dev-feedback removed
  • Owner changed from westonruter to obenland
  • Status changed from accepted to assigned

I applied the patch and did git diff -w and the diff came up empty, so there are no changes other than whitespace. I also tried editing CSS and I got the expected linting messages.

#3 @obenland
7 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 42110:

Codemirror: Unify line endings in csslint.js

This is likely a problem caused upstream and will probably be a non-issue once #41870 is merged in a future release.

Fixes #42424.

Note: See TracTickets for help on using tickets.