WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#42424 closed defect (bug) (fixed)

Codemirror: Unify line endings in csslint.js

Reported by: obenland Owned by: obenland
Priority: normal Milestone: 4.9
Component: Customize Version: 4.9
Severity: normal Keywords: has-patch dev-reviewed commit
Cc: Focuses:

Description

The csslint.js file comes with severe line ending and possibly whitespace issues, to a degree where it makes the file basically unmergeable in larger WordPress installations.

This is likely a problem caused upstream and will probably be a non-issue once #41870 is merged in the next release.

Attachments (1)

42424.diff​ (240.6 KB ) - added by obenland 9 years ago.

Download all attachments as: .zip

Change History (4)

@obenland
9 years ago

#1 @westonruter
9 years ago

  • Keywords dev-feedback added
  • Owner set to westonruter
  • Status new → accepted

#2 @westonruter
9 years ago

  • Keywords dev-reviewed commit added; dev-feedback removed
  • Owner changed from westonruter to obenland
  • Status accepted → assigned

I applied the patch and did git diff -w and the diff came up empty, so there are no changes other than whitespace. I also tried editing CSS and I got the expected linting messages.

#3 @obenland
9 years ago

  • Resolution → fixed
  • Status assigned → closed

In 42110:

Codemirror: Unify line endings in csslint.js

This is likely a problem caused upstream and will probably be a non-issue once #41870 is merged in a future release.

Fixes #42424.

Note: See TracTickets for help on using tickets.