WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#4243 closed defect (bug) (fixed)

Properly handle uploaded files for blogroll imports

Reported by: apokalyptik Owned by:
Milestone: 2.3 Priority: normal
Severity: normal Version:
Component: Administration Keywords:
Focuses: Cc:

Description

Fix 1 since wp_remote_fopen does not properly handle local files versus remote urls (and by the name of the function probably should not do so anyhow ("remote" and all that) Uploading a file instead of linking to a file already on the web for import caused $opml to be set as boolean false. This in turn was not very parse-able by the xml routines. So I wrapped the setting of $opml in an if statement that would use file_get_contents() for local files and wp_remote_fopen() for remote files.


Fix 2 unlinking an uploaded file for import should pass the file through the wp_delete_file filter.

Attachments (1)

changeset_trunk_wp-admin_link-import.php.diff (644 bytes) - added by apokalyptik 7 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 ryan7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5438]) Handle local and remote blogroll imports. Props apokalyptik. fixes #4243 for 2.2

comment:2 ryan7 years ago

(In [5439]) Handle local and remote blogroll imports. Props apokalyptik. fixes #4243 for 2.3

comment:3 rob1n7 years ago

  • Milestone changed from 2.4 to 2.3
Note: See TracTickets for help on using tickets.