WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #42437, comment 44


Ignore:
Timestamp:
12/05/2019 06:54:49 PM (12 months ago)
Author:
pbiron
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #42437, comment 44

    initial v1  
    33> I agree. This is a "far fetched" edge case but since we're trying to fix "all" cases, perhaps good to account for it too :)
    44
    5 "far fetched", maybe; "real world", definitely!  It's actually the case that brought this ticket to my attention last year.  An artist uploaded an image with a "dimension-like" filename to a site...no conflicts at that time.  I later changed themes, the new theme changed sub-sizes so I regenerated thumbnails and found the artist's original image had been overridden.
     5"far fetched", maybe; "real world", definitely!  It's actually the case that brought this ticket to my attention last year.  An artist uploaded an image with a "dimension-like" filename to a site...no conflicts at that time.  I later changed themes, the new theme changed sub-sizes so I regenerated thumbnails and found the artist's original image had been overritten.
    66
    77> BTW, the unit tests seem to pass here with 42437.3.diff. Lets look at adding some more :)