WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #42437, comment 46


Ignore:
Timestamp:
12/05/2019 10:57:19 PM (12 months ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #42437, comment 46

    initial v1  
    11Replying to [comment:44 pbiron]:
     2> I later changed themes, the new theme changed sub-sizes so I regenerated thumbnails and found the artist's original image had been overritten.
     3
     4Yeah, makes sense.
     5
    26> What's the process for addng new images to `tests/phpunit/data/images`?  Not sure how to do that with "regular" a patch.  For more unit tests we'll need some additional test images to test against.
    37
    4 Yeah, there's no good way to add "binary" files. If you upload the images here, I can add them separately when committing the tests (images should be copyright free/in "public domain").
     8There's no good way to add "binary" files to diffs. If you upload the images here, I can add them separately when committing the tests (images should be copyright free/in "public domain").
    59
    610