| 8 | | Actually, as we are only testing the file names, thinking we don't need new image files, can "replicate" an existing image in the test dir and rename it appropriately. Looking at adding few more tests now. |
| | 8 | On the other hand we are only testing the file names, thinking we don't need new image files, can "replicate" an existing image in the test dir and rename it appropriately. |
| | 9 | |
| | 10 | Looking further, seems the tests in 42437.2.diff cover it pretty well. Just need to extend the second to cover cases where an image with identical name was uploaded, i.e. have `one-blue-pixel-100x100.png` and `one-blue-pixel-1-100x100.png`. |
| | 11 | |
| | 12 | Thinking this is ready for trunk. @pbiron if you see other possible tests, please add them in a separate patch :) |