WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #42437, comment 48


Ignore:
Timestamp:
12/06/2019 10:18:33 PM (12 months ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #42437, comment 48

    initial v1  
    66> I was thinking of the color swatches that Alex already attached to this ticket (and maybe a few more like them).
    77
    8 Actually, as we are only testing the file names, thinking we don't need new image files, can "replicate" an existing image in the test dir and rename it appropriately. Looking at adding few more tests now.
     8On the other hand we are only testing the file names, thinking we don't need new image files, can "replicate" an existing image in the test dir and rename it appropriately.
     9
     10Looking further, seems the tests in 42437.2.diff cover it pretty well. Just need to extend the second to cover cases where an image with identical name was uploaded, i.e. have `one-blue-pixel-100x100.png` and `one-blue-pixel-1-100x100.png`.
     11
     12Thinking this is ready for trunk. @pbiron if you see other possible tests, please add them in a separate patch :)