WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

#42447 closed defect (bug) (fixed)

Mark test_remove_orientation_data_on_rotate as skipped when exif_read_data isn't available

Reported by: danielbachhuber's profile danielbachhuber Owned by: desrosj's profile desrosj
Milestone: 4.9.2 Priority: normal
Severity: normal Version:
Component: Media Keywords: has-patch commit
Focuses: Cc:

Description

The test_remove_orientation_data_on_rotate test, which calls wp_read_image_metadata(), has a dependency on the EXIF PHP extension. If the exif_read_data function isn't available, this test should be skipped.

Attachments (2)

42447.1.diff​ (670 bytes) - added by danielbachhuber 6 years ago.
42447.2.diff​ (611 bytes) - added by desrosj 5 years ago.
Refreshed patch.

Download all attachments as: .zip

Change History (5)

@danielbachhuber
6 years ago

@desrosj
5 years ago

Refreshed patch.

#1 @desrosj
5 years ago

  • Keywords commit added
  • Owner set to desrosj
  • Status changed from new to assigned

#2 @desrosj
5 years ago

  • Milestone changed from Future Release to 4.9.2

#3 @mikeschroder
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 42431:

Media: Skip test_remove_orientation_data_on_rotate if missing deps.

The test_remove_orientation_data_on_rotate() test was failing on systems that did not have the exif extension available.

Skips test when the exif_read_data() function does not exist.

Props danielbachhuber, desrosj.
Fixes #42447.

Note: See TracTickets for help on using tickets.