Unable to translate codex URL in theme-editor.php

[odysseygate]

the string "​https://codex.wordpress.org/Child_Themes" exists, but it cant be translated 'cause of missing translate function.

[odysseygate]

Fixed the function from escape to translate.

[dd32]

Thanks for reporting @odysseygate!

You're right, this URL should probably be translated, however the patch should probably be esc_url( __() ) instead (That can be changed upon commit if needed)

This would be an additional string, the Child_Themes URL isn't translated anywhere else.

Marking as 4.9.1, although this is small enough to slip into 4.9 if so desired ( @melchoyce ) -

[odysseygate]

@dd32 OK, i understand 4.9 is about to release soon, so ill leave it up to you.

The Child_Themes URL has already translated on help tab in the same theme-editor.php. see https://core.trac.wordpress.org/browser/trunk/src/wp-admin/theme-editor.php?marks=39#L39.

[melchoyce]

Let's do this for 4.9.1 👍

[johnpgreen]

Updated patch.

[dd32]

In 42247:

Theme Editor: Translate the URL to the Child Themes Codex page.

Props odysseygate, johnpgreen.
Fixes #42454.

[dd32]

I completely missed that this string was already translated (I only checked the admin text domain, not the global text domain). Lets push this out.

[dd32]

In 42248:

Theme Editor: Translate the URL to the Child Themes Codex page.

Props odysseygate, johnpgreen.
Merges [42247] to the 4.9 branch.
Fixes #42454.