WordPress.org

Make WordPress Core

Opened 5 weeks ago

Closed 2 weeks ago

Last modified 2 weeks ago

#42454 closed defect (bug) (fixed)

Unable to translate codex URL in theme-editor.php

Reported by: odysseygate Owned by: dd32
Milestone: 4.9.1 Priority: normal
Severity: normal Version: 4.9
Component: Text Changes Keywords: has-patch
Focuses: Cc:

Description

the string "https://codex.wordpress.org/Child_Themes" exists, but it cant be translated 'cause of missing translate function.

Attachments (2)

42454.diff (1.1 KB) - added by odysseygate 5 weeks ago.
Fixed the function from escape to translate.
42454.patch (790 bytes) - added by johnpgreen 3 weeks ago.

Download all attachments as: .zip

Change History (11)

@odysseygate
5 weeks ago

Fixed the function from escape to translate.

#1 @dd32
5 weeks ago

  • Keywords has-patch needs-refresh i18n-change added
  • Milestone changed from Awaiting Review to 4.9.1

Thanks for reporting @odysseygate!

You're right, this URL should probably be translated, however the patch should probably be esc_url( __() ) instead (That can be changed upon commit if needed)

This would be an additional string, the Child_Themes URL isn't translated anywhere else.

Marking as 4.9.1, although this is small enough to slip into 4.9 if so desired ( @melchoyce ) -

#2 @odysseygate
5 weeks ago

@dd32 OK, i understand 4.9 is about to release soon, so ill leave it up to you.

The Child_Themes URL has already translated on help tab in the same theme-editor.php. see https://core.trac.wordpress.org/browser/trunk/src/wp-admin/theme-editor.php?marks=39#L39.

Last edited 5 weeks ago by odysseygate (previous) (diff)

#3 @melchoyce
5 weeks ago

Let's do this for 4.9.1 👍

@johnpgreen
3 weeks ago

#4 @johnpgreen
3 weeks ago

  • Keywords needs-refresh removed

Updated patch.

#5 @johnbillion
3 weeks ago

  • Component changed from Administration to Text Changes

#6 @johnbillion
3 weeks ago

  • Milestone changed from 4.9.1 to 4.9.2

#7 @dd32
2 weeks ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 42247:

Theme Editor: Translate the URL to the Child Themes Codex page.

Props odysseygate, johnpgreen.
Fixes #42454.

#8 @dd32
2 weeks ago

  • Keywords i18n-change removed
  • Milestone changed from 4.9.2 to 4.9.1

I completely missed that this string was already translated (I only checked the admin text domain, not the global text domain). Lets push this out.

#9 @dd32
2 weeks ago

In 42248:

Theme Editor: Translate the URL to the Child Themes Codex page.

Props odysseygate, johnpgreen.
Merges [42247] to the 4.9 branch.
Fixes #42454.

Note: See TracTickets for help on using tickets.