WordPress.org

Make WordPress Core

Opened 21 months ago

Closed 21 months ago

Last modified 21 months ago

#42476 closed defect (bug) (fixed)

Minor Grammar in 4.9 Administration

Reported by: garrett-eclipse Owned by: westonruter
Milestone: 4.9 Priority: normal
Severity: normal Version: 4.9
Component: Help/About Keywords: has-patch dev-reviewed
Focuses: Cc:

Description

Pretty minor but ‘Roles and Capability Improvements’ should be ‘Roles and Capabilities Improvements’
Permalink - https://translate.wordpress.org/projects/wp/dev/admin/en-ca/default?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=5267460&filters%5Btranslation_id%5D=52677920

Attachments (3)

42476.diff (1.1 KB) - added by metodiew 21 months ago.
42476.2.diff (1.1 KB) - added by westonruter 21 months ago.
prepositional-phrase.png (291.6 KB) - added by westonruter 21 months ago.

Download all attachments as: .zip

Change History (15)

This ticket was mentioned in Slack in #meta-i18n by garrett-eclipse. View the logs.


21 months ago

#2 @tobifjellner
21 months ago

So the corresponding place in the code would be https://core.trac.wordpress.org/browser/trunk/src/wp-admin/about.php?marks=214#L214

<h3><a href="https://make.wordpress.org/core/2017/10/15/improvements-for-roles-and-capabilities-in-4-9/"><?php _e( 'Roles and Capability Improvements' ); ?></a></h3>

It’s just a bit sad that we’re in hard string freeze right now. But if some strings will be changing in 4.9.1 then this would be a good candidate!

@metodiew
21 months ago

#3 @metodiew
21 months ago

  • Keywords has-patch added

We are at WordCamp Sofia Contributor Day and I was waiting for someone to claim the ticket. :)

It looks like no one noticed the ticket, so I've attached a small patch.

#4 @ocean90
21 months ago

  • Milestone changed from Awaiting Review to 4.9

Moving for visibility. Typos on the about page should be avoided, not matter if we're in string freeze.

#5 @ocean90
21 months ago

  • Component changed from Administration to Help/About

#6 @ocean90
21 months ago

  • Version changed from trunk to 4.9

#7 @melchoyce
21 months ago

Patch looks good. @ocean90 or @westonruter do you want to do a final review + commit?

#8 @westonruter
21 months ago

@melchoyce There's too many plural nouns combined together here. If we change it I think it should be changed as:

- Roles and Capability Improvements
+ Improvements to Roles and Capabilities

#9 @westonruter
21 months ago

  • Keywords dev-reviewed added

#10 @westonruter
21 months ago

  • Owner set to westonruter
  • Resolution set to fixed
  • Status changed from new to closed

In 42159:

About: Fix grammar typo with pluralization.

Props metodiew, westonruter.
Amends [42121].
See #42087.
Fixes #42476 for trunk.

#11 @westonruter
21 months ago

In 42160:

About: Fix grammar typo with pluralization.

Props metodiew, westonruter.
Amends [42121].
See #42087.
Fixes #42476 for 4.9.

#12 @garrett-eclipse
21 months ago

Wow I'm honoured, thank you all for pushing my fix through a string freeze.

Note: See TracTickets for help on using tickets.