WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#42483 closed task (blessed) (fixed)

Shrinkwrap npm dependencies for 4.9

Reported by: netweb's profile netweb Owned by: ocean90's profile ocean90
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch commit dev-feedback
Focuses: Cc:

Description

Previous milestone references: 4.8 in #40928, 4.7 in #38657, 4.6 in #37541, 4.5 in #36498

Notes:

  1. The npm-shrinkwrap.json is generated using NodeJS 6.9.1 and npm 3.10.10, see #38657#comment:9
  1. The npm-shrinkwrap.json excludes the fsevents optional dependency and has been manually removed, see 4.7's [39368].

Attachments (1)

42483.diff​ (208.7 KB) - added by netweb 7 years ago.

Download all attachments as: .zip

Change History (9)

@netweb
7 years ago

#1 @netweb
7 years ago

  • Keywords has-patch commit added

#2 @westonruter
7 years ago

  • Keywords dev-feedback added
  • Owner set to ocean90
  • Status changed from new to reviewing

@ocean90 I see you've committed this at least once in the past. Would you review and do the same for this?

#3 @westonruter
7 years ago

  • Owner changed from ocean90 to nacin

@nacin Or, rather, would you review?

This ticket was mentioned in ​Slack in #core by jeffpaul. ​View the logs.
7 years ago

#5 @westonruter
7 years ago

  • Owner changed from nacin to ocean90

#6 @ocean90
7 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 42166:

Build: Add npm-shrinkwrap.json.

For compatibility with the build server fsevent has been manually removed.

Props netweb.
Fixes #42483.

#7 @ocean90
7 years ago

In 42167:

Revert [42166].

Due to running npm install an updated npm-shrinkwrap.json file was committed.

See #42483.

#8 @ocean90
7 years ago

In 42168:

Build: Add npm-shrinkwrap.json.

For compatibility with the build server fsevent has been manually removed.

Props netweb.
See #42483.

Note: See TracTickets for help on using tickets.