#42491 closed defect (bug) (fixed)
Theme Editor: Styling skewed for notice displayed in file list when editing a child theme
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.9 | Priority: | normal |
Severity: | normal | Version: | 5.1 |
Component: | General | Keywords: | has-patch dev-reviewed has-screenshots commit |
Focuses: | ui | Cc: |
Description
When editing files for child theme in the new editor, the styling is a bit skewed because there is an alert added letting the user know white are editing a child theme. See a screenshot here https://www.dropbox.com/s/yp0zi2egkcd8uep/wp-file-editor.png?dl=0. I suggest the alert be moved into the <ul> that makes up the file list and then all that is needed is some additional padding tweets.
Attachments (6)
Change History (15)
#2
@
7 years ago
- Component changed from Editor to Plugins
- Focuses ui added
- Keywords needs-patch added
- Milestone changed from Awaiting Review to 4.9
#3
@
7 years ago
- Keywords has-patch dev-feedback added; needs-patch removed
- Owner set to melchoyce
- Status changed from new to reviewing
@melchoyce What do you think of applied-42491.0.png?
#5
@
7 years ago
- Component changed from Plugins to General
- Summary changed from File editor styling skewed when editing a child theme to Theme Editor: Styling skewed for notice displayed in file list when editing a child theme
#6
@
7 years ago
Made a super tiny padding tweak in 42491.2.diff. I think it's good to go now!
Note: See
TracTickets for help on using
tickets.
Thanks for catching. Sounds like a good solution 👍
Are you interested in making a patch, or should we open it up to anyone who wants to?