WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#42491 closed defect (bug) (fixed)

Theme Editor: Styling skewed for notice displayed in file list when editing a child theme

Reported by: ndiego Owned by: westonruter
Priority: normal Milestone: 4.9
Component: General Version: 5.1
Severity: normal Keywords: has-patch dev-reviewed has-screenshots commit
Cc: Focuses: ui

Description

When editing files for child theme in the new editor, the styling is a bit skewed because there is an alert added letting the user know white are editing a child theme. See a screenshot here ​https://www.dropbox.com/s/yp0zi2egkcd8uep/wp-file-editor.png?dl=0. I suggest the alert be moved into the <ul> that makes up the file list and then all that is needed is some additional padding tweets.

Attachments (6)

wp-file-editor_preview.png​ (31.2 KB ) - added by westonruter 9 years ago.
42491.0.diff​ (2.1 KB ) - added by westonruter 9 years ago.
applied-42491.0.png​ (85.1 KB ) - added by westonruter 9 years ago.
42491.1.diff​ (2.3 KB ) - added by westonruter 9 years ago.
applied-42491.1.png​ (86.1 KB ) - added by westonruter 9 years ago.
Fix applied on mobile
42491.2.diff​ (2.4 KB ) - added by melchoyce 9 years ago.

Download all attachments as: .zip

Change History (15)

#1 @melchoyce
9 years ago

Thanks for catching. Sounds like a good solution 👍

Are you interested in making a patch, or should we open it up to anyone who wants to?

#2 @johnbillion
9 years ago

  • Component Editor → Plugins
  • Focuses ui added
  • Keywords needs-patch added
  • Milestone Awaiting Review → 4.9

@westonruter
9 years ago

@westonruter
9 years ago

@westonruter
9 years ago

#3 @westonruter
9 years ago

  • Keywords has-patch dev-feedback added; needs-patch removed
  • Owner set to melchoyce
  • Status new → reviewing

@melchoyce What do you think of applied-42491.0.png​?

@westonruter
9 years ago

@westonruter
9 years ago

Fix applied on mobile

#4 @westonruter
9 years ago

  • Keywords has-screenshots added

#5 @westonruter
9 years ago

  • Component Plugins → General
  • Summary File editor styling skewed when editing a child theme → Theme Editor: Styling skewed for notice displayed in file list when editing a child theme

@melchoyce
9 years ago

#6 @melchoyce
9 years ago

Made a super tiny padding tweak in 42491.2.diff​. I think it's good to go now!

#7 @westonruter
9 years ago

  • Keywords dev-reviewed commit added; dev-feedback removed
  • Owner changed from melchoyce to westonruter
  • Status reviewing → accepted

#8 @westonruter
9 years ago

  • Resolution → fixed
  • Status accepted → closed

In 42155:

Theme Editor: Fix styling of child theme notice.

Props westonruter, melchoyce, ndiego.
See #24048.
Fixes #42491 for trunk.

#9 @westonruter
9 years ago

In 42156:

Theme Editor: Fix styling of child theme notice.

Props westonruter, melchoyce, ndiego.
See #24048.
Fixes #42491 for 4.9.

Note: See TracTickets for help on using tickets.