WordPress.org

Make WordPress Core

Opened 2 months ago

Closed 7 days ago

#42492 closed defect (bug) (fixed)

Selecting menu location changes line height

Reported by: obenland Owned by: westonruter
Milestone: 4.9.2 Priority: normal
Severity: normal Version: 4.9
Component: Customize Keywords: fixed-major
Focuses: ui Cc:

Description

In the Customizer, when editing a menu, and selecting a location for it, the line height changes, pushing down the following settings by a pixel.

Introduced in [41817].

Attachments (3)

32614986-b918423a-c52b-11e7-95b6-b27def0658f7.gif (1.5 MB) - added by obenland 2 months ago.
42492.diff (594 bytes) - added by obenland 2 months ago.
42492.2.diff (455 bytes) - added by obenland 2 months ago.

Download all attachments as: .zip

Change History (12)

#1 @obenland
2 months ago

  • Keywords has-screenshots added

@obenland
2 months ago

#2 @obenland
2 months ago

  • Keywords has-patch added

#3 @bpayton
2 months ago

@obenland Thanks for doing this. Just a heads up: I noticed the ticket number was accidentally added to the CSS in the diff.

@obenland
2 months ago

#4 @obenland
2 months ago

Good catch. Updated, thanks!

#5 @westonruter
2 months ago

  • Owner set to westonruter
  • Resolution set to fixed
  • Status changed from new to closed

In 42152:

Customize: Prevent nav menu location assignment checkbox change from increasing height by 1px.

Props obenland.
Amends [41817].
See #42157.
Fixes #42492.

#6 @johnbillion
2 months ago

  • Keywords fixed-major added; has-screenshots has-patch removed
  • Milestone changed from 4.9.1 to 4.9.2
  • Resolution fixed deleted
  • Status changed from closed to reopened

#7 @johnbillion
2 months ago

  • Keywords fixed-major removed
  • Milestone changed from 4.9.2 to 4.9
  • Resolution set to fixed
  • Status changed from reopened to closed

#8 @johnbillion
2 months ago

  • Keywords fixed-major added
  • Milestone changed from 4.9 to 4.9.2
  • Resolution fixed deleted
  • Status changed from closed to reopened

This went into trunk but not into the 4.9 branch, but wasn't re-opened with fixed-major.

#9 @SergeyBiryukov
7 days ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 42436:

Customize: Prevent nav menu location assignment checkbox change from increasing height by 1px.

Props obenland.
Amends [41817].
Merges [42152] to the 4.9 branch.
See #42157.
Fixes #42492.

Note: See TracTickets for help on using tickets.