WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 22 months ago

Last modified 22 months ago

#42497 closed defect (bug) (fixed)

Customize: 'Changeset already published' message isn't always accurate

Reported by: dlh Owned by: westonruter
Milestone: 4.9.3 Priority: normal
Severity: normal Version: 4.9
Component: Customize Keywords: fixed-major has-patch i18n-change
Focuses: Cc:
PR Number:

Description

When opening a changeset on customize.php where the changeset has the status of publish or trash, the error message is This changeset has already been published and cannot be further modified.

Although published changesets are trashed by default, so too are discarded changesets as of 4.9. The error message isn't quite accurate in the case of a discarded changeset, though.

One way to change the string so it applies in both cases might be shortening it to This changeset cannot be further modified or This set of changes cannot be further modified.

Attachments (1)

42497.diff (689 bytes) - added by dlh 2 years ago.

Download all attachments as: .zip

Change History (10)

@dlh
2 years ago

#1 @westonruter
2 years ago

  • Milestone changed from Awaiting Review to 4.9.1

#2 @westonruter
2 years ago

  • Owner set to westonruter
  • Resolution set to fixed
  • Status changed from new to closed

In 42150:

Customize: Improve accuracy of message displayed when accessing Customizer with a changeset that is already published or trashed.

Amends [38810].
Props dlh.
Fixes #42497.

#3 @johnbillion
2 years ago

  • Keywords fixed-major added; has-patch removed
  • Milestone changed from 4.9.1 to 4.9.2
  • Resolution fixed deleted
  • Status changed from closed to reopened

#4 @johnbillion
2 years ago

This went into trunk but not into the 4.9 branch, but wasn't re-opened with fixed-major.

This ticket was mentioned in Slack in #core-customize by westonruter. View the logs.


22 months ago

#6 @dd32
22 months ago

  • Milestone changed from 4.9.2 to 4.9.3

Bumping to 4.9.3 due to 4.9.2s release

This ticket was mentioned in Slack in #core by desrosj. View the logs.


22 months ago

#8 @westonruter
22 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 42535:

Customize: Improve accuracy of message displayed when accessing Customizer with a changeset that is already published or trashed.

Amends [38810].
Props dlh.
Fixes #42497 for 4.9 branch.

#9 @ocean90
22 months ago

  • Keywords has-patch i18n-change added
Note: See TracTickets for help on using tickets.