#42505 closed task (blessed) (fixed)
Docblock improvements for 5.1
Reported by: | johnbillion | Owned by: | |
---|---|---|---|
Milestone: | 5.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | General | Keywords: | |
Focuses: | docs | Cc: |
Attachments (8)
Change History (68)
#3
@
7 years ago
@afercia in #42530:
- ...seems to me all the new functions introduced in [41630] miss a @since notation in their docblocks.
- Additional note about documentation standards: many multiline inline comments introduced in [41630] use a double asterisk, e.g.:
/** * If the selection is on a shortcode with Live View, TinyMCE creates a bogus markup, * which we have to account for. */- Note: one more coding standard that isn't met across [41630]: Declaring Variables With var
- Each function should begin with a single comma-delimited var statement that declares any local variables necessary
This ticket was mentioned in Slack in #gdpr-compliance by desrosj. View the logs.
6 years ago
#41
@
6 years ago
42505.2.diff fixes typo and variable formatting in the inline description of wp_add_inline_script()
and wp_add_inline_style()
.
#42
@
6 years ago
42505.3.diff removes an extra } from the inline description for
wp_page_menu()
. I wonder if it was meant to be {@see wp_list_pages()
}, but it seems to be unnecessary as the link is already generated on:
https://developer.wordpress.org/reference/functions/wp_page_menu/
#44
@
6 years ago
- Add missing
@param
and@return
descriptions toWP_Scripts->localize()
. - Add missing periods at the end of inline comments.
- Fix parameter alignment for
WP_Scripts->add_inline_script()
andWP_Scripts->set_group()
.
#47
@
6 years ago
The patch in 42505-wp-login.diff contains suggestions for wp-login.php
that:
- Adds missing
@since
annotation for the action:user_request_action_confirmed
- Adds missing
@since
annotation for the functions:wp_shake_js()
,wp_login_viewport_meta()
,retrieve_password()
,login_header()
,login_footer()
.
- Adds missing description for the functions:
wp_shake_js()
,wp_login_viewport_meta()
.
- Adds missing full-stops for inline comments.
- Capitalizes inline comments.
- Capitalizes https and ssl in inline comments.
#52
@
6 years ago
- Milestone changed from 5.0 to 5.1
- Summary changed from Docblock improvements for 5.0 to Docblock improvements for 5.1
Renaming and moving to the 5.1 milestone due to the WordPress 5.0 focus on the new
editor (Gutenberg).
In 42143: