Error messages rendered by JS are not translated

[munyagu]

This messages do not appear in GlotPress.

'There is %d error which must be fixed before you can save.'
​https://github.com/WordPress/WordPress/blob/e8229a25d5f4c620ef5f021abe70224cc6c550de/wp-includes/widgets/class-wp-widget-custom-html.php#L180

This one is translated but not reflected online.

'Your PHP code changes were rolled back due to an error on line %1$s of file %2$s. Please fix and try saving again.'
​https://github.com/WordPress/WordPress/blob/e8229a25d5f4c620ef5f021abe70224cc6c550de/wp-admin/includes/file.php#L303

​https://translate.wordpress.org/projects/wp/dev/admin/ja/default?filters%5Bterm%5D=Please+fix+and+try+saving+again&filters%5Buser_login%5D=&filters%5Bstatus%5D=current_or_waiting_or_fuzzy_or_untranslated&filter=Filter&sort%5Bby%5D=priority&sort%5Bhow%5D=desc

see:https://wordpress.slack.com/archives/C02RP50LK/p1510283499000069

[swissspidy]

There is %d error which must be fixed before you can save.

I can see this string in GlotPress, under the "4.9.x - Development" project.

This one is translated but not reflected online.

Make sure you're using updated translation files on your site

[munyagu]

There is %d error which must be fixed before you can save.

I can see this string in GlotPress, under the "4.9.x - Development" project.

It's in ja.po but not in admin-ja.po.

This one is translated but not reflected online.

Make sure you're using updated translation files on your site

I tried again and it was translated.
Sorry.

[martian36]

Hi, I updated to recent nightly build 4.9-RC2-42149 and also the translations, but the issue is the same.

[swissspidy]

It's in ja.po but not in admin-ja.po.

That's correct. Strings are in either ja.po OR admin-ja.po, not in both. ​https://github.com/WordPress/WordPress/blob/e8229a25d5f4c620ef5f021abe70224cc6c550de/wp-includes/widgets/class-wp-widget-custom-html.php#L180 is not in wp-admin, thus the string won't be in admin-ja.po anyway.

[munyagu]

Does it mean the messages for the administrative screens, which are arguments to the translation functions, are not translated on the administration screen?
Is it correct？

These messages are included in decompiled my ja.mo.
These messages means "There is %d error which must be fixed before you can save." and "Unable to save due to %s invalid setting.".

[Presskopp]

Same issue with german - I even downloaded the full translation package and replaced the one I got on my HD, I've seen the translations are in the .po - but no. I wonder if it has to do with the usage of _n_noop in script-loader.php.

[Mirucon]

I am getting the same issue.

I can confirm that the string is in the .po file and I tried to compile to .mo file from the po file (so the mo file must have the string), but still getting same.

Tested on WP 4.9-RC2, VCCW, with Japanese translation.

[munyagu]

@swissspidy
I did not recognize, not only admin-ja.mo but also ja.mo is load in administration screen.
I noticed that customizer preview would not be displayed unless aja.mo was loaded with @Presskopp comment.

[odysseygate]

_n may have the same trouble.

[odysseygate]

Im getting the same issue, too.
In addition of _n_noop, _n seems to be unable to reflect translation: https://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-wp-customize-manager.php?marks=2702#L2702

[ocean90]

As mentioned in the DocBlock, _n_noop() does not translate strings. So the use of wp_array_slice_assoc() and _n_noop() doesn't really work.

For a possible workaround without string changes see 42510.patch​ (incomplete). Not perfect, ideally it should be two separate strings until we have a proper i18n API in JS.

[westonruter]

Replying to odysseygate:

Im getting the same issue, too.
In addition of _n_noop, _n seems to be unable to reflect translation: https://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-wp-customize-manager.php?marks=2702#L2702

Maybe it's because that same string appears with _n_noop() in script-loader.php:

​https://github.com/WordPress/wordpress-develop/blob/48980cd/src/wp-includes/script-loader.php#L589-L593

Whereas it appears with _n() in class-wp-customize-manager.php:

​https://github.com/WordPress/wordpress-develop/blob/48980cd/src/wp-includes/class-wp-customize-manager.php#L2699-L2703

Maybe the _n_noop() is clobbering the _n(). I confess I don't understand the mechanics of i18n very well.

[dd32]

Replying to westonruter:

Maybe the _n_noop() is clobbering the _n(). I confess I don't understand the mechanics of i18n very well.

The issue is the _n_noop() doesn't perform translations - it's literally an array passthrough for use later by translate_nooped_plural() - it's not an issue of being clobbered.
​https://developer.wordpress.org/reference/functions/_n_noop/ has an example of that usage (plus the source of the function there)

So instead, it should pass through a translated 'singular' and a translated 'plural' string to JS (be that two _n()'s using 1 & 2 as the count as in 42510.patch​, or literally __() twice), both of those will be incorrect in some languages, but as @ocean90 said, until we have a JS translation API such as what Gutenberg is using, we have no other way to do it properly.

Maybe it's because that same string appears with _n_noop() in script-loader.php:

Just to note, if it's not clear - all of those _n_noop() calls there will need changing, as they're all not currently translated strings.

[westonruter]

42510.2.diff​ fixes the the remaining JS-targeted usages of _n_noop().

In all I count 4 instances:

1. Error message when adding invalid HTML to the Custom HTML widget.
2. Error message in Customizer's global notification area when there is an invalid setting.
3. Error message in Customizer's Additional CSS when there is a syntax error.
4. Error message in theme/plugin editor when there are linting errors.

@dd32 @ocean90 Would either of you dev-reviewed and commit to trunk and the 4.9 branch so translators can get to work prior to a planned RC3 in ~12 hours?

[Mirucon]

42510.2.diff​ looks good to me!

[dd32]

42510.2.diff​ Looks good to me, tested that a translated string appears in the custom CSS error message, would like someone who can read a non-en locale verify it too though :)

Tested using Japanese, and the original string in question appears translated (Tested using trunk) - ​https://cloudup.com/cxMxRfcHWZS

[Mirucon]

I can see the strings in the image (​https://cloudup.com/cxMxRfcHWZS) are translated properly. Looks good to commit.

[westonruter]

In 42163:

I18N: Fix passing singular/plural strings to JS.

This is a temporary solution while waiting for full I18N support in JS.

Props ocean90, dd32, westonruter, Mirucon for testing.
Amends [41376], [41721], [41389],
See #20491.
Fixes #42510 for trunk.

[westonruter]

In 42164:

I18N: Fix passing singular/plural strings to JS.

This is a temporary solution while waiting for full I18N support in JS.

Props ocean90, dd32, westonruter, Mirucon for testing.
Amends [41376], [41721], [41389].
See #20491.
Fixes #42510 for 4.9.