WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #42510, comment 16


Ignore:
Timestamp:
11/13/2017 01:28:20 AM (2 years ago)
Author:
dd32
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #42510, comment 16

    initial v1  
    77So instead, it should pass through a translated 'singular' and a translated 'plural' string to JS (be that two `_n()`'s using 1 & 2 as the count as in [attachment:42510.patch], or literally `__()` twice), both of those will be incorrect in some languages, but as @ocean90 said, until we have a JS translation API such as what Gutenberg is using, we have no other way to do it properly.
    88
     9
     10> Maybe it's because that same string appears with _n_noop() in script-loader.php:
     11Just to note, if it's not clear - all of those `_n_noop()` calls there will need changing, as they're all not currently translated strings.