WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#42514 closed defect (bug) (fixed)

Scrolling Titles in 4.9 About Page Flash

Reported by: danieltj Owned by: ryelle
Milestone: 4.9 Priority: normal
Severity: normal Version: 4.9
Component: Administration Keywords: has-patch
Focuses: ui Cc:
PR Number:

Description

I decided I'd do some testing with the 4.9 release (currently using RC2) and noticed on the about page, when you scroll down there are some titles that follow you down the page. It seems that when you get to the bottom of a container, the title disappears as you scroll on down to the next section. If you scroll back up again then the title will suddenly appear once again.

The .floating-header-section h2 element should have a position of absolute when it gets scrolled down to the bottom boundary of that section. Currently, when you reach the bottom, the top attribute gets reset to 0 so it looks like it's flashing when really it's just jumping up to the top.

A fix for this would be to set a position of absolute when the title hits the very bottom of it's section container so it appears to stick to the bottom.

Attachments (1)

49about.jpg (74.4 KB) - added by danieltj 2 years ago.

Download all attachments as: .zip

Change History (13)

@danieltj
2 years ago

#1 @danieltj
2 years ago

  • Keywords needs-patch good-first-bug added

This seems like it'll need a bit of JavaScript to ensure the titles top attribute gets set correctly when it hits the bottom of the container and also watch for the window being resized reducing the number of lines the content sits on which will ultimately make the page longer.

#2 @westonruter
2 years ago

@melchoyce Is this something that we should fix for the 4.9 release?

#3 @melchoyce
2 years ago

@ryelle is going to try to take a look later today. However, if she can’t get to it in time, I’m inclined to leave it as-is — unless it’s causing performance issues, or flashing bad enough to cause headaches in motion-sensitive people.

#4 @obenland
2 years ago

I might just be a matter of reducing the throttle timeout

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


2 years ago

#7 @jbpaul17
2 years ago

  • Owner set to ryelle
  • Status changed from new to assigned

#8 @ryelle
2 years ago

  • Keywords has-patch added; needs-patch removed

FYI for anyone following this ticket, I've uploaded a patch to #42526 which also addresses the scrolling title issue - direct link to patch.

#9 @westonruter
2 years ago

  • Keywords good-first-bug removed
  • Milestone changed from Awaiting Review to 4.9

Will be fixed by patch on #42526.

#10 @westonruter
2 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 42173:

About: Fix jumping behavior for titles and columns when scrolling.

Props ryelle.
See #42087.
Fixes #42514, #42526.

#11 @westonruter
2 years ago

In 42174:

About: Fix jumping behavior for titles and columns when scrolling.

Props ryelle.
See #42087.
Fixes #42514, #42526 for 4.9.

#12 @westonruter
2 years ago

In 42181:

About Page: Fix issue with overlapping images and text on IE11 and Edge 15.

Props Clorith, ryelle, afercia, la-geek, SergeyBiryukov.
See #42514.
Fixes #42545.

Note: See TracTickets for help on using tickets.