Make WordPress Core

Opened 7 years ago

Last modified 6 weeks ago

#42522 assigned defect (bug)

Terms are uselessly counted when saving a post

Reported by: chouby's profile Chouby Owned by: pbearne's profile pbearne
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 3.3
Component: Taxonomy Keywords: has-patch has-unit-tests
Focuses: performance Cc:

Description

This occurs even when terms have not been modified and when the post status has not changed. This is due to _update_term_count_on_transition_post_status not checking if the post status has been modified.

Attachments (1)

42522.diff (950 bytes) - added by Chouby 7 years ago.

Download all attachments as: .zip

Change History (7)

@Chouby
7 years ago

#1 @Chouby
7 years ago

  • Keywords has-patch added

#2 @johnbillion
7 years ago

  • Keywords reporter-feedback added

What about the situation where a published post gets its terms changed but the status doesn't change? It looks like this change would cause the term count for newly added terms to get out of sync.

#3 @Chouby
7 years ago

  • Keywords reporter-feedback removed

In that case, wp_set_object_terms calls wp_update_term_count, so the term count should be correctly udpated.

This ticket was mentioned in PR #6793 on WordPress/wordpress-develop by @pbearne.


6 weeks ago
#4

The modification ensures that term counts are only updated when the post's status has truly changed. This reduces unnecessary operations, improving performance when there is no status change on a post.

#5 @pbearne
6 weeks ago

  • Owner set to pbearne
  • Status changed from new to assigned

refreshed patch

#6 @pbearne
6 weeks ago

  • Keywords has-unit-tests added
Note: See TracTickets for help on using tickets.