Opened 7 years ago
Last modified 8 months ago
#42522 assigned defect (bug)
Terms are uselessly counted when saving a post
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | Awaiting Review | Priority: | normal |
Severity: | normal | Version: | 3.3 |
Component: | Taxonomy | Keywords: | has-patch has-unit-tests |
Focuses: | performance | Cc: |
Description
This occurs even when terms have not been modified and when the post status has not changed. This is due to _update_term_count_on_transition_post_status
not checking if the post status has been modified.
Attachments (1)
Change History (7)
#3
@
7 years ago
- Keywords reporter-feedback removed
In that case, wp_set_object_terms
calls wp_update_term_count
, so the term count should be correctly udpated.
This ticket was mentioned in PR #6793 on WordPress/wordpress-develop by @pbearne.
8 months ago
#4
The modification ensures that term counts are only updated when the post's status has truly changed. This reduces unnecessary operations, improving performance when there is no status change on a post.
Note: See
TracTickets for help on using
tickets.
What about the situation where a published post gets its terms changed but the status doesn't change? It looks like this change would cause the term count for newly added terms to get out of sync.