WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 months ago

Last modified 8 months ago

#4253 closed enhancement (worksforme)

Category feeds don't indicate they are category feeds

Reported by: RuddO Owned by:
Milestone: Priority: lowest
Severity: trivial Version:
Component: Feeds Keywords:
Focuses: Cc:

Description

Okay guys, here is a patch for WordPress that properly titles and describes category RSS/Atom feeds. I didn't know how to set the URL for the feed to the URL of the category, so what I'm doing is just leaving the bloginfo URL as it is, but I hope you can whip that out from your fabulous hacking heads.

This patch makes sense because of several reasons. My personal reason is that I'm running a magazine with different sections (using categories as the section) at rudd-o.com, and I'm encouraging subscriptions to the section feeds instead of the whole magazine, but the feeds themselves don't say which category they're from. Now with this patch they do.

Another thing that I'm not sure about, and I'd like a response in the form of a comment here (I'm tracking this bug via RSS): do I have to htmlspecialchars() before doing the print's "..." in this patch? The question, more properly phrased, is: if I print a get_category_name(), should I print it htmlspecialchar()red, or should I just print it out, and trust that the WordPress category administrator won't let people type random HTML? Another way of posing the question would be: if I type an ampersand (&) in the category name, what should the theme display, "&" or "&"? This is keeping me up at night, need some sleep, please help =).

Attachments (2)

diff (3.1 KB) - added by RuddO 8 years ago.
Patch to make category feeds show actually category descriptions and names
rss-category-description.diff (3.6 KB) - added by RuddO 8 years ago.
Updated patch for 2.2

Download all attachments as: .zip

Change History (17)

@RuddO8 years ago

Patch to make category feeds show actually category descriptions and names

comment:1 @rob1n8 years ago

I think this is already done. My 2.2 blog has the category title in the <title> field in the category feed.

comment:2 @rob1n8 years ago

  • Milestone changed from 2.2 to 2.4

comment:3 @RuddO8 years ago

But does it set the proper description? What about the URL for the corresponding HTML alternate page (the category archive)?

comment:4 @rob1n8 years ago

  • Milestone changed from 2.4 to 2.3
  • Owner changed from anonymous to rob1n
  • Status changed from new to assigned

True, and might as well give it an overhaul. Targeting 2.3.

comment:5 @rob1n8 years ago

  • Status changed from assigned to new

@RuddO8 years ago

Updated patch for 2.2

comment:6 @foolswisdom8 years ago

  • Keywords has-patch added
  • Milestone changed from 2.3 to 2.4 (next)

comment:7 @rob1n8 years ago

  • Owner rob1n deleted

comment:8 @westi7 years ago

  • Component changed from General to Template
  • Keywords needs-patch added; has-patch removed
  • Milestone changed from 2.5 to 2.6

Hmm.

I am not sure about this.

As it is the current patch is too repetitive and a better proposal would be to introduce a new feed template function for the description field which contains the decision code and a filter for plugins to alter what is displayed.

Moving to 2.6 for now and marking as needs-patch

comment:9 @Denis-de-Bernardy6 years ago

  • Milestone changed from 2.9 to Future Release

still needs patch

comment:10 @Denis-de-Bernardy6 years ago

  • Component changed from Template to Feeds

comment:11 @peaceablewhale6 years ago

I will try to fix this in #9510.

comment:12 @peaceablewhale6 years ago

  • Keywords needs-patch removed

The updated patch in #9510 should fix this as well.

comment:13 @chriscct711 months ago

#9510 would implement this if done

comment:14 @stevenkword8 months ago

  • Keywords close added
  • Priority changed from normal to lowest
  • Resolution set to fixed
  • Severity changed from normal to trivial
  • Status changed from new to closed

I am closing this ticket since the original problem has been addressed via the wp_title_rss() function. This function also already provides filters to customize the feed descriptions as needed.

comment:15 @ocean908 months ago

  • Keywords close removed
  • Milestone Future Release deleted
  • Resolution changed from fixed to worksforme
Note: See TracTickets for help on using tickets.