Remove checkered background for icons in Attachment Details

[SergeyBiryukov]

#41948 added a checkered background for transparent images in Attachment Details modal.

This is not necessary for icons, see the screenshot. Adjusting [41569] to only apply the styles to images without .icon class should fix the issue.

To reproduce, upload a PDF file to a server without Imagick, ImageMagick, or Ghostscript, and open the Attachment Details window.

[SergeyBiryukov]

To reproduce, upload a PDF file to a server without Imagick, ImageMagick, or Ghostscript, and open the Attachment Details window.

Can be reproduced with a ZIP file as well.

[BandonRandon]

Tested in Chromium and Firefox but could use further testing.

Another option would be to use the CSS3 Selector of :not(.icon) for the background properties but the override method in the patch is perhaps simpler.

[BandonRandon]

After patch applied

[janak007]

Added patch to fix the background image

[BandonRandon]

Hi @janak007 I could be missing something but it looks like your patch is always removing the checked background added in #41948.

The background image itself should remain just be hidden when an icon is shown (like with a PDF or video file). This should be what happens when you apply 42535.diff Could you test to make sure that's happening for you?

As a small administrative note, when iterating an existing patch to a ticket it's generally recommended to add a patch number. For example, your patch would be 42535.2.diff. This makes it easy to see the latest patch to grab when testing.

Thanks for contributing to WordPress core :)

[SergeyBiryukov]

In 42642:

Media: Remove checkered background for icons in Attachment Details.

Props BandonRandon.
Fixes #42535. See #41948.

[johnbillion]

[42642] should be merged into 5.0

[pento]

👍🏻

[SergeyBiryukov]

In 43745:

Media: Remove checkered background for icons in Attachment Details.

Props BandonRandon.
Merges [42642] to the 5.0 branch.
Fixes #42535. See #41948.