WordPress.org

Make WordPress Core

Opened 4 weeks ago

Last modified 3 weeks ago

#42535 new defect (bug)

Remove checkered background for icons in Attachment Details

Reported by: SergeyBiryukov Owned by:
Milestone: 5.0 Priority: normal
Severity: normal Version:
Component: Media Keywords: good-first-bug has-patch needs-testing
Focuses: ui, administration Cc:

Description

#41948 added a checkered background for transparent images in Attachment Details modal.

This is not necessary for icons, see the screenshot. Adjusting [41569] to only apply the styles to images without .icon class should fix the issue.

To reproduce, upload a PDF file to a server without Imagick, ImageMagick, or Ghostscript, and open the Attachment Details window.

Attachments (3)

42535.PNG (15.6 KB) - added by SergeyBiryukov 4 weeks ago.
42535.diff (449 bytes) - added by BandonRandon 4 weeks ago.
Screen Shot 2017-11-14 at 12.09.29 AM.png (266.3 KB) - added by BandonRandon 4 weeks ago.
After patch applied

Download all attachments as: .zip

Change History (7)

@SergeyBiryukov
4 weeks ago

#1 in reply to: ↑ description @SergeyBiryukov
4 weeks ago

To reproduce, upload a PDF file to a server without Imagick, ImageMagick, or Ghostscript, and open the Attachment Details window.

Can be reproduced with a ZIP file as well.

#2 @BandonRandon
4 weeks ago

  • Keywords has-patch needs-testing added; needs-patch removed

Tested in Chromium and Firefox but could use further testing.

Another option would be to use the CSS3 Selector of :not(.icon) for the background properties but the override method in the patch is perhaps simpler.

@BandonRandon
4 weeks ago

@BandonRandon
4 weeks ago

After patch applied

#3 @johnbillion
4 weeks ago

  • Milestone changed from Awaiting Review to 4.9.1

#4 @johnbillion
3 weeks ago

  • Milestone changed from 4.9.1 to 5.0
Note: See TracTickets for help on using tickets.