Minor type in class-wp-editor.php

[GunGeekATX]

There's a minor typo in the get_translation() function, an extra space at the end of the 'Edit' field.

'Edit ' => __( 'Edit' ), // Tooltip for the 'edit' button in the image toolbar

[SergeyBiryukov]

It's not a typo, see the comment in wpeditimage/plugin.js​.

It does look weird though, maybe something like Edit|button could be used instead.

[welcher]

Replying to SergeyBiryukov:

It's not a typo, see the comment in wpeditimage/plugin.js​.

It does look weird though, maybe something like Edit|button could be used instead.

Thanks for the clarification on that @SergeyBiryukov! I Perhaps the fix is either to use 'Edit|button` as you suggested or at the very least, add an inline comment that has a similar comment and references the JS files?

[scottlee]

Here's a patch for updating the comment from wpeditimage/plugin.js. I briefly tried updating the edit to Edit|button but it wasn't getting parsed correctly for me.

[ayubadiputra]

Sorry for the second patch, just learned how to submit a patch. I think the first patch from @scottlee is better and simpler.

[XpertOne]

Replying to SergeyBiryukov:
@scottlee has submitted the patch but the ticket is still labeled as 'needs patch' , do we still need a patch for this ?

[welcher]

Due to [42343] this patch needs a refresh.

[SergeyBiryukov]

In 42523:

Editor: Use explicit context instead of a trailing space for Edit string in TinyMCE plugins.

Props scottlee, ayubadiputra, NathanAtmoz.
Fixes #42543.

[desrosj]

In 44401:

Editor: Use explicit context instead of a trailing space for Edit string in TinyMCE.

In [42523], trunk was updated to use explicit context instead of a trailing space for the Edit string in TinyMCE plugins. [43472] later backported this change, but the string in class-wp-editor.php was missed. This fixes the Edit string so not display as Edit|button in the 5.0 branch.

Props dimadin.

See #42543, #44134.
Fixes #44919.