WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 21 months ago

Last modified 10 months ago

#42543 closed defect (bug) (fixed)

Minor type in class-wp-editor.php

Reported by: GunGeekATX Owned by: SergeyBiryukov
Milestone: 5.1 Priority: normal
Severity: normal Version: 5.1
Component: Editor Keywords: good-first-bug has-patch
Focuses: ui, docs Cc:
PR Number:

Description

There's a minor typo in the get_translation() function, an extra space at the end of the 'Edit' field.

'Edit ' => __( 'Edit' ), // Tooltip for the 'edit' button in the image toolbar

Attachments (3)

42543.diff (1.0 KB) - added by scottlee 2 years ago.
42543.2.diff (1.0 KB) - added by ayubadiputra 2 years ago.
42543.3.diff (1.2 KB) - added by NathanAtmoz 23 months ago.

Download all attachments as: .zip

Change History (18)

#1 @welcher
2 years ago

  • Keywords needs-patch good-first-bug added

#2 @welcher
2 years ago

  • Milestone changed from Awaiting Review to 4.9.1

#3 @welcher
2 years ago

  • Milestone changed from 4.9.1 to Future Release

#4 follow-up: @SergeyBiryukov
2 years ago

It's not a typo, see the comment in wpeditimage/plugin.js.

It does look weird though, maybe something like Edit|button could be used instead.

#5 in reply to: ↑ 4 @welcher
2 years ago

Replying to SergeyBiryukov:

It's not a typo, see the comment in wpeditimage/plugin.js.

It does look weird though, maybe something like Edit|button could be used instead.

Thanks for the clarification on that @SergeyBiryukov! I Perhaps the fix is either to use 'Edit|button` as you suggested or at the very least, add an inline comment that has a similar comment and references the JS files?

#6 @welcher
2 years ago

  • Focuses ui docs added

#7 @scottlee
2 years ago

Here's a patch for updating the comment from wpeditimage/plugin.js. I briefly tried updating the edit to Edit|button but it wasn't getting parsed correctly for me.

@scottlee
2 years ago

@ayubadiputra
2 years ago

#8 @ayubadiputra
2 years ago

Sorry for the second patch, just learned how to submit a patch. I think the first patch from @scottlee is better and simpler.

#9 follow-up: @SergeyBiryukov
2 years ago

  • Milestone changed from Future Release to 5.0

#10 in reply to: ↑ 9 @XpertOne
2 years ago

Replying to SergeyBiryukov:
@scottlee has submitted the patch but the ticket is still labeled as 'needs patch' , do we still need a patch for this ?

#11 @welcher
23 months ago

  • Keywords needs-refresh has-patch added; needs-patch removed

Due to [42343] this patch needs a refresh.

#12 @NathanAtmoz
22 months ago

  • Keywords needs-refresh removed

#13 @SergeyBiryukov
21 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 42523:

Editor: Use explicit context instead of a trailing space for Edit string in TinyMCE plugins.

Props scottlee, ayubadiputra, NathanAtmoz.
Fixes #42543.

#14 @johnbillion
12 months ago

  • Milestone changed from 5.0 to 5.1

#15 @desrosj
10 months ago

In 44401:

Editor: Use explicit context instead of a trailing space for Edit string in TinyMCE.

In [42523], trunk was updated to use explicit context instead of a trailing space for the Edit string in TinyMCE plugins. [43472] later backported this change, but the string in class-wp-editor.php was missed. This fixes the Edit string so not display as Edit|button in the 5.0 branch.

Props dimadin.

See #42543, #44134.
Fixes #44919.

Note: See TracTickets for help on using tickets.