WordPress.org

Make WordPress Core

Opened 17 months ago

Closed 17 months ago

Last modified 17 months ago

#42556 closed defect (bug) (fixed)

IE11: Customizer always sends you into the theme-selector screen

Reported by: Clorith Owned by: westonruter
Milestone: 4.9 Priority: normal
Severity: normal Version: 4.9
Component: Customize Keywords: has-patch dev-reviewed commit
Focuses: ui, javascript Cc:

Description

In IE11, when loading the customizer, or when installing and previewing a new theme, you are always sent into Themes > WordPress.org themes screen.

To elaborate:
From any screen in wp-admin or the admin bar, click Customize (or via the menu, Themes > Customize), the customizer loads, then moves you automatically o the Theme selector screen to find a new theme from WordPress.org

Second scenario, when you've picked a theme, you click "Install & Preview", after waiting for the theme to download (should this line have said downlaod and preview instead of install?) you are once again dropped into the screen to select a new theme to download and preview.

Attachments (1)

42556.0.diff (620 bytes) - added by westonruter 17 months ago.

Download all attachments as: .zip

Change History (12)

#1 @melchoyce
17 months ago

  • Milestone changed from Awaiting Review to 4.9

This ticket was mentioned in Slack in #core-committers by westonruter. View the logs.


17 months ago

#3 @westonruter
17 months ago

  • Keywords has-patch needs-testing added; needs-patch removed

For some reason IE11 an input event fires on the search field even when the panel isn't expanded. Easy fix here: ignore events when the panel is not expanded.

@Clorith please test 42556.0.diff.

#4 @Clorith
17 months ago

42556.0.diff does the trick!

#6 @westonruter
17 months ago

  • Keywords dev-feedback commit added; needs-testing removed

This ticket was mentioned in Slack in #core by westonruter. View the logs.


17 months ago

#8 @SergeyBiryukov
17 months ago

  • Keywords dev-reviewed added; dev-feedback removed

#9 @westonruter
17 months ago

  • Owner set to westonruter
  • Status changed from new to accepted

#10 @westonruter
17 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 42187:

Customize: Prevent themes panel from auto-expanding in IE11.

In IE11 the input event erroneously gets triggered initially without any user input.

Amends [41648].
See #37661.
Fixes #42556 for trunk.

#11 @westonruter
17 months ago

In 42188:

Customize: Prevent themes panel from auto-expanding in IE11.

In IE11 the input event erroneously gets triggered initially without any user input.

Amends [41648].
See #37661.
Fixes #42556 for 4.9.

Note: See TracTickets for help on using tickets.