Context Navigation

← Previous Ticket
Next Ticket →

#42564 closed defect (bug) (fixed)

Use `promote_users` for role updates in edit_user()

Reported by:	ocean90	Owned by:	ocean90
Priority:	normal	Milestone:	5.1
Component:	Role/Capability	Version:
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:

Description

edit_user() can also update user roles but is still using the edit_users capability instead of the newer promote_users capability introduced in [14176].

We have a similar role handling in https://core.trac.wordpress.org/browser/tags/4.8.3/src/wp-admin/users.php?marks=96-97,121-128#L93 and should copy that to edit_user() for consistency.

Change edit_users to promote_users
Change manage_site to manage_network_users

Attachments (2)

42564.diff (1.9 KB ) - added by ocean90 9 years ago.: Also props to @jjj and @flixos90
42564.2.diff (4.0 KB ) - added by ocean90 8 years ago.

Download all attachments as: .zip

Change History (5)

@ocean90
9 years ago

Attachment 42564.diff added

Also props to @jjj and @flixos90

#1 @johnbillion
9 years ago

Milestone 4.9.1 → 5.0

@ocean90
8 years ago

Attachment 42564.2.diff added

#2 @ocean90
8 years ago

Owner set to ocean90
Resolution → fixed
Status new → closed

In 42855:

Users: Use promote_users for role updates in edit_user().

edit_user() can also update user roles but was still using the edit_users capability instead of the newer promote_users capability introduced in [14176].
This makes the role handling consistent with the bulk dropdown menu for role changes.

Props flixos90, johnjamesjacoby, ocean90.
Fixes #42564.

#3 @johnbillion
8 years ago

Milestone 5.0 → 5.1

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core