WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Last modified 4 days ago

#42568 new enhancement

Text Widget: Media Uploader Button Label

Reported by: sauravrox's profile saurav.rox Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Widgets Keywords: has-patch 2nd-opinion
Focuses: Cc:

Description

I was wondering if the Media Uploader in the new Text Widget has a button with label Insert Into Widget instead of Insert Into Post as shown here: ​http://prntscr.com/hb38jv . It would be more meaningful I guess :)

Attachments (2)

42568.diff​ (553 bytes) - added by sabernhardt 4 days ago.
replaces "Insert into post" text with "Add media" in classic widgets and the Customizer
insert-button-customizer.png​ (53.1 KB) - added by sabernhardt 4 days ago.
"Add media" button (in Customizer)

Download all attachments as: .zip

Change History (4)

#1 @sabernhardt
5 years ago

  • Component changed from General to Widgets
  • Keywords needs-patch added
  • Summary changed from Media Uploader Button Label to Text Widget: Media Uploader Button Label
  • Version 4.9 deleted

@sauravrox Thanks for the suggestion!

Yes, I see the text widget still has "Insert into post" for the media insert button, and "Insert into post" would be more meaningful.

Version 0, edited 5 years ago by sabernhardt (next)

@sabernhardt
4 days ago

replaces "Insert into post" text with "Add media" in classic widgets and the Customizer

@sabernhardt
4 days ago

"Add media" button (in Customizer)

#2 @sabernhardt
4 days ago

  • Keywords has-patch 2nd-opinion added; needs-patch removed

The "Insert into post" text comes from the ​default 'insert_into_item' text.

The legacy Text Widget might not be worth creating a new string now, but I tried reusing the same "Add media" text (from the heading) for the button. That should not affect registered post types, only the classic widgets administration screen and the widgets panel of the Customizer.

Note: See TracTickets for help on using tickets.