Opened 18 years ago
Closed 17 years ago
#4259 closed enhancement (fixed)
Text & page widget improvemets
Reported by: | Denis-de-Bernardy | Owned by: | rob1n |
---|---|---|---|
Milestone: | 2.2.2 | Priority: | normal |
Severity: | normal | Version: | 2.2 |
Component: | Administration | Keywords: | has-patch |
Focuses: | Cc: |
Description (last modified by )
XP SP2, IE7
The errors that the attached screenshot will highlight have been around on wordpress.com for longer than I can remember. I'm surprised noone has ever bothered to file them.
In addition, please be so kind to apply the attached patch. It does the following:
- add an option to wpautop text widgets
- add an option to exclude pages from the pages widget
- sort page widgets using menu_order rather than by their title
Attachments (4)
Change History (31)
#2
@
18 years ago
- Owner changed from anonymous to rob1n
- Status changed from new to assigned
- Summary changed from Has anyone bothered to test widgets in Internet Explorer? to Text & page widget improvemets
So your patch doesn't fix errors in IE 7? ...
#6
@
18 years ago
- Priority changed from high to normal
- Severity changed from blocker to normal
- Type changed from defect to enhancement
#7
@
18 years ago
wp_list_pages() should sort by menu_order,post_title by default. As for the options, I'd rather wait until 2.2.x. We're planning to add a bunch of options to the widgets.
#10
follow-up:
↓ 12
@
18 years ago
if you apply the filter 'the_content', you'll get plenty bugs with plugins along the lines of podpress. e.g. if the last post in the loop has media attached to it, each text widget will have a few media links.
also, the page exclude is heavily requested (at least among the users I'm babysitting).
D.
#11
@
18 years ago
lastly, in the text widget's title, if the title is empty, it is turned into a non-breaking space. this defeats the purpose of:
<?php !empty( $title ) ? print($before_title . $title . $after_title) : null; ?>
D.
#12
in reply to:
↑ 10
@
18 years ago
Replying to Denis-de-Bernardy:
if you apply the filter 'the_content', you'll get plenty bugs with plugins along the lines of podpress. e.g. if the last post in the loop has media attached to it, each text widget will have a few media links.
Makes sense. I guess we can make the text widget its own filter.
also, the page exclude is heavily requested (at least among the users I'm babysitting).
Next thing I'm looking at :).
#13
@
18 years ago
autop and texturize are breaking the Google Reader Clip snippet. script tags are peed on and the script src is texturized. Since text widgets are commonly used for such snippets, we need to make sure we don't break them.
#14
@
18 years ago
Which brings me back to my original proposal for making texturize/autop a checkbox :).
#19
@
18 years ago
Some plugins append things to the_content making it unsuitable for widget use. We can add a widget_text or generic text_content filter. I'd like to get autop and texturize playing nicely first.
#25
in reply to:
↑ description
@
18 years ago
Replying to Denis-de-Bernardy:
The errors that the attached screenshot will highlight have been around on wordpress.com for longer than I can remember. I'm surprised noone has ever bothered to file them.
*chuckle* We have. :)
If your patch doesn't fix the IE7 issue, you should create a new ticket for it, and explain the reasoning behind it.