WordPress.org

Make WordPress Core

Opened 2 years ago

Last modified 9 days ago

#42594 assigned task (blessed)

Clean up svn properties on develop

Reported by: dd32 Owned by: desrosj
Milestone: 5.4 Priority: normal
Severity: normal Version:
Component: General Keywords:
Focuses: Cc:
PR Number:

Description

A number of files have random svn: properties set that they don't need - it's probably time to clean these out.

svn:executable is set on 23 files, none of which need it.

svn:keywords is set on 96 files, again, none of which need it - and may actually cause issue in the future if we ever end up using an $Author variable in a file with it (It does substitution). Thankfully there's a 0-intersect between the the keywords and files that have the property currently.

svn:eol-style doesn't appear to be set on all files consistently either, and should be set on all text/editable files.

Change History (13)

#1 @dd32
2 years ago

  • Milestone changed from Awaiting Review to 5.0
  • Owner set to dd32
  • Status changed from new to accepted

#2 @dd32
2 years ago

In 42200:

Remove the svn:executable property from files that don't need it.

See #42594

#3 @dd32
2 years ago

In 42201:

Remove the svn:keywords property from files that don't need it.

See #42594

#4 follow-up: @johnbillion
12 months ago

Anything else left to do here @dd32 ?

#5 @pento
12 months ago

  • Milestone changed from 5.0 to 5.1

#6 in reply to: ↑ 4 @dd32
12 months ago

  • Owner dd32 deleted
  • Status changed from accepted to assigned

Replying to johnbillion:

Anything else left to do here @dd32 ?

Not sure, a lot has happened in develop.svn since then - AFAIK there were still a lot of stray properties after [42201] that still needed cleaning up, if anyone cares enough to comb through it.

#8 @afercia
9 months ago

#45412 was marked as a duplicate.

#9 @afercia
9 months ago

The svn:eol-style was reported also in #45412, closed as duplicate.

#10 @pento
9 months ago

It'd help to add auto-props to the repo, so we don't keep having to do this. These are all the extensions in the repo, a few extra pairs of eyes to check that I got them all would be helpful.

### Source files
*.css = svn:eol-style=native
*.js = svn:eol-style=native
*.php = svn:eol-style=native
*.py = svn:eol-style=native

### Font files
*.eot = svn:mime-type=application/octet-stream
*.otf = svn:mime-type=application/octet-stream
*.ttf = svn:mime-type=application/octet-stream
*.woff = svn:mime-type=application/octet-stream
*.woff2 = svn:mime-type=application/octet-stream

### Image files
*.bmp = svn:mime-type=application/octet-stream
*.gif = svn:mime-type=application/octet-stream
*.ico = svn:mime-type=application/octet-stream
*.jp2 = svn:mime-type=application/octet-stream
*.jpg = svn:mime-type=application/octet-stream
*.pct = svn:mime-type=application/octet-stream
*.png = svn:mime-type=application/octet-stream
*.psd = svn:mime-type=application/octet-stream
*.sgi = svn:mime-type=application/octet-stream
*.svg = svn:eol-style=native
*.tga = svn:mime-type=application/octet-stream
*.tiff = svn:mime-type=application/octet-stream

### Video files
*.mkv = svn:mime-type=application/octet-stream
*.mov = svn:mime-type=application/octet-stream
*.mp4 = svn:mime-type=application/octet-stream
*.webm = svn:mime-type=application/octet-stream

### Audio files
*.flac = svn:mime-type=application/octet-stream
*.mp3 = svn:mime-type=application/octet-stream

### Document files
*.csv = svn:eol-style=native
*.dfxp = svn:eol-style=native
*.docx = svn:mime-type=application/octet-stream
*.html = svn:eol-style=native
*.md = svn:eol-style=native
*.pdf = svn:mime-type=application/octet-stream
*.rtf = svn:mime-type=application/octet-stream
*.tsv = svn:eol-style=native
*.txt = svn:eol-style=native
*.vtt = svn:eol-style=native

### Translation files
*.mo = svn:eol-style=native
*.po = svn:mime-type=application/octet-stream
*.pot = svn:eol-style=native

### Config files
*.dist = svn:eol-style=native
*.jshintrc = svn:eol-style=native
*.json = svn:eol-style=native
*.lock = svn:eol-style=native
*.xml = svn:eol-style=native
*.yml = svn:eol-style=native

### Miscellaneous
*.crt = svn:eol-style=native
*.map = svn:eol-style=native
*.nodelete = svn:eol-style=native

To fix up the existing problems, something like these commands will do:

find -E . -regex '.*\.(css|js|php|py)' | xargs -I {} svn propset svn:eol-style native '{}'
find -E . -regex '.*\.(bmp|gif|ico|jp2|jpg)' | xargs -I {} svn propset svn:mime-type application/octet-stream '{}'

#11 @pento
9 months ago

  • Milestone changed from 5.1 to 5.2

Also, as much as I enjoy changing pretty much every file in the repo, I'm going to leave this until 5.2.

#12 @johnbillion
7 months ago

  • Milestone changed from 5.2 to Future Release
  • Type changed from defect (bug) to task (blessed)

#13 @desrosj
9 days ago

  • Milestone changed from Future Release to 5.4
  • Owner set to desrosj

I'll follow up on this and wrap it up after 5.3 is branched.

Note: See TracTickets for help on using tickets.