Remove extra space in menus post body content

[Shital Patel]

Remove Space In Menu Text

[Hardik Amipara]

Change in nav-menus.css

[Hardik Amipara]

After Remove bottom space in text

[welcher]

@Shital Patel thanks for the ticket and welcome to trac!

@Hardik Amipara thank you for the patches! Typically patches are generated from the root of the repository ( at the same level that contains the /src directory ). I have taken the liberty of regenerating the patch from there.

Also, I did some tests with the patch and found that when the following rule is applied:

.nav-menus-php #post-body #post-body-content{ 
     margin-bottom: 0px; 
}

We are losing the padding below the Menu Settings

I had refactored the patch slightly to accommodate.

[Hardik Amipara]

change in .post-body-plain class and id #post-body

[Hardik Amipara]

Add one space before ".nav-menus-php #post-body-content .post-body-plain {"

[Hardik Amipara]

Add new class .post-body-plain after .nav-menus-php #post-body-content

[welcher]

@Hardik Amipara can you please regenerate the patch from the repository root? Have a look at the patch I uploaded for reference.

[Hardik Amipara]

yes @welcher I added new patch. thank you for the inform me. :)

[welcher]

@Hardik Amipara it still looks to be the same - how are you generating the patch?

[Hardik Amipara]

New Patch Added

[Hardik Amipara]

Replying to welcher:
By using svn. This is my 1st contribution. So let me know if any changes.

[welcher]

@Hardik Amipara thanks for your contributions on this!

The code is great, the issue where the patch is being generated from. Are you using command line?

If so, please move up to the root level ( see the screenshot attached ) and then run the svn diff command from there.

The patch that is generated will be the same code but will be able to be applied from the root. You can see that it is correct by viewing the patch to confirm that there is a full path to the file src/wp-admin/css/nav-menus.css instead of nav-menus.css

Don't get discouraged, you're doing great and there is always a learning curve with contributing to core :)

[welcher]

Repo root

[Hardik Amipara]

root src level patch

[Hardik Amipara]

src level patch - add one space after "{"

[Hardik Amipara]

Replying to welcher:

Thank you so much for guide me. :)

I added src root level patch

[audrasjb]

patch refreshed against trunk

[desrosj]

In 44952:

Menus: Ensure consistent padding in the menu structure form.

Props shital-patel, welcher, hardik-amipara, audrasjb.
Fixes #42596.