Make WordPress Core

Opened 6 years ago

Closed 5 years ago

#42596 closed enhancement (fixed)

Remove extra space in menus post body content

Reported by: shital-patel's profile Shital Patel Owned by: audrasjb's profile audrasjb
Milestone: 5.2 Priority: normal
Severity: normal Version: 4.9
Component: Menus Keywords: has-patch commit
Focuses: ui, administration Cc:

Description


Attachments (17)

RemoveSpaceInMenuText.png (32.3 KB) - added by Shital Patel 6 years ago.
Remove Space In Menu Text
42596.patch (340 bytes) - added by Hardik Amipara 6 years ago.
Change in nav-menus.css
after_RemoveSpaceInMenuText.png (22.8 KB) - added by Hardik Amipara 6 years ago.
After Remove bottom space in text
42596.2.patch (492 bytes) - added by Hardik Amipara 6 years ago.
menus-42596.png (38.4 KB) - added by welcher 6 years ago.
42596.3.patch (521 bytes) - added by welcher 6 years ago.
42596.4.patch (485 bytes) - added by Hardik Amipara 6 years ago.
change in .post-body-plain class and id #post-body
chnage_post-body_paddind_and_reset_post-body-content_margin-bottom.png (39.3 KB) - added by Hardik Amipara 6 years ago.
remove_space_in_post-body-plain.png (27.9 KB) - added by Hardik Amipara 6 years ago.
42596.5.patch (486 bytes) - added by Hardik Amipara 6 years ago.
Add one space before ".nav-menus-php #post-body-content .post-body-plain {"
42596.6.patch (524 bytes) - added by Hardik Amipara 6 years ago.
Add new class .post-body-plain after .nav-menus-php #post-body-content
42596.2.2.patch (524 bytes) - added by Hardik Amipara 6 years ago.
42596.3.2.patch (481 bytes) - added by Hardik Amipara 6 years ago.
New Patch Added
repo_root.png (26.3 KB) - added by welcher 6 years ago.
Repo root
42596.4.2.patch (642 bytes) - added by Hardik Amipara 6 years ago.
root src level patch
42596.5.2.patch (643 bytes) - added by Hardik Amipara 6 years ago.
src level patch - add one space after "{"
42596.7.diff (597 bytes) - added by audrasjb 5 years ago.
patch refreshed against trunk

Download all attachments as: .zip

Change History (35)

@Shital Patel
6 years ago

Remove Space In Menu Text

#1 @Hardik Amipara
6 years ago

Last edited 6 years ago by Hardik Amipara (previous) (diff)

@Hardik Amipara
6 years ago

Change in nav-menus.css

@Hardik Amipara
6 years ago

After Remove bottom space in text

#2 @Shital Patel
6 years ago

  • Keywords needs-patch added

#3 @Hardik Amipara
6 years ago

  • Keywords has-patch added; needs-patch removed

@welcher
6 years ago

#4 @welcher
6 years ago

@Shital Patel thanks for the ticket and welcome to trac!

@Hardik Amipara thank you for the patches! Typically patches are generated from the root of the repository ( at the same level that contains the /src directory ). I have taken the liberty of regenerating the patch from there.

Also, I did some tests with the patch and found that when the following rule is applied:

.nav-menus-php #post-body #post-body-content{ 
     margin-bottom: 0px; 
}

We are losing the padding below the Menu Settings

I had refactored the patch slightly to accommodate.

@welcher
6 years ago

@Hardik Amipara
6 years ago

change in .post-body-plain class and id #post-body

@Hardik Amipara
6 years ago

Add one space before ".nav-menus-php #post-body-content .post-body-plain {"

@Hardik Amipara
6 years ago

Add new class .post-body-plain after .nav-menus-php #post-body-content

#5 @welcher
6 years ago

  • Focuses ui administration added

#6 @welcher
6 years ago

  • Keywords needs-refresh added; has-patch removed

@Hardik Amipara can you please regenerate the patch from the repository root? Have a look at the patch I uploaded for reference.

#7 @Hardik Amipara
6 years ago

yes @welcher I added new patch. thank you for the inform me. :)

#8 follow-up: @welcher
6 years ago

@Hardik Amipara it still looks to be the same - how are you generating the patch?

@Hardik Amipara
6 years ago

New Patch Added

#9 in reply to: ↑ 8 @Hardik Amipara
6 years ago

Replying to welcher:
By using svn. This is my 1st contribution. So let me know if any changes.

#10 follow-up: @welcher
6 years ago

@Hardik Amipara thanks for your contributions on this!

The code is great, the issue where the patch is being generated from. Are you using command line?

If so, please move up to the root level ( see the screenshot attached ) and then run the svn diff command from there.

The patch that is generated will be the same code but will be able to be applied from the root. You can see that it is correct by viewing the patch to confirm that there is a full path to the file src/wp-admin/css/nav-menus.css instead of nav-menus.css

Don't get discouraged, you're doing great and there is always a learning curve with contributing to core :)

Last edited 6 years ago by welcher (previous) (diff)

@welcher
6 years ago

Repo root

@Hardik Amipara
6 years ago

root src level patch

@Hardik Amipara
6 years ago

src level patch - add one space after "{"

#11 in reply to: ↑ 10 @Hardik Amipara
6 years ago

Replying to welcher:

Thank you so much for guide me. :)

I added src root level patch

#12 @welcher
6 years ago

  • Keywords has-patch added; needs-refresh removed
  • Milestone changed from Awaiting Review to 5.0
  • Type changed from defect (bug) to enhancement

#13 @johnbillion
5 years ago

  • Milestone changed from 5.0 to 5.1

#14 @pento
5 years ago

  • Milestone changed from 5.1 to 5.2

#15 @Shital Patel
5 years ago

  • Keywords needs-refresh added

@audrasjb
5 years ago

patch refreshed against trunk

#16 @audrasjb
5 years ago

  • Keywords needs-refresh removed

#17 @audrasjb
5 years ago

  • Keywords commit added
  • Owner set to audrasjb
  • Status changed from new to accepted

#18 @desrosj
5 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 44952:

Menus: Ensure consistent padding in the menu structure form.

Props shital-patel, welcher, hardik-amipara, audrasjb.
Fixes #42596.

Note: See TracTickets for help on using tickets.