WordPress.org

Make WordPress Core

Opened 8 years ago

Last modified 8 years ago

#4259 closed enhancement

Text & page widget improvemets — at Version 22

Reported by: Denis-de-Bernardy Owned by: rob1n
Milestone: 2.2.2 Priority: normal
Severity: normal Version: 2.2
Component: Administration Keywords: has-patch
Focuses: Cc:

Description (last modified by rob1n)

XP SP2, IE7

The errors that the attached screenshot will highlight have been around on wordpress.com for longer than I can remember. I'm surprised noone has ever bothered to file them.

In addition, please be so kind to apply the attached patch. It does the following:

  1. add an option to wpautop text widgets
  2. add an option to exclude pages from the pages widget
  3. sort page widgets using menu_order rather than by their title

Change History (26)

@Denis-de-Bernardy8 years ago

@Denis-de-Bernardy8 years ago

comment:1 @matt8 years ago

If your patch doesn't fix the IE7 issue, you should create a new ticket for it, and explain the reasoning behind it.

comment:2 @rob1n8 years ago

  • Owner changed from anonymous to rob1n
  • Status changed from new to assigned
  • Summary changed from Has anyone bothered to test widgets in Internet Explorer? to Text & page widget improvemets

So your patch doesn't fix errors in IE 7? ...

comment:3 @rob1n8 years ago

Open another ticket for the IE 7 bug.

comment:4 @rob1n8 years ago

Also, we should wp_texturize() the text widget's contents.

comment:5 @rob1n8 years ago

  • Keywords has-patch added

comment:6 @rob1n8 years ago

  • Priority changed from high to normal
  • Severity changed from blocker to normal
  • Type changed from defect to enhancement

comment:7 @ryan8 years ago

wp_list_pages() should sort by menu_order,post_title by default. As for the options, I'd rather wait until 2.2.x. We're planning to add a bunch of options to the widgets.

comment:8 @rob1n8 years ago

  • Milestone changed from 2.2 to 2.2.1

comment:9 @rob1n8 years ago

(In [5486]) Texturize and autop the text widgets, and allow pages to be sorted by a specified field. Props Denis de Bernardy. see #4259

@rob1n8 years ago

page order + text widget filters

comment:10 follow-up: @Denis-de-Bernardy8 years ago

if you apply the filter 'the_content', you'll get plenty bugs with plugins along the lines of podpress. e.g. if the last post in the loop has media attached to it, each text widget will have a few media links.

also, the page exclude is heavily requested (at least among the users I'm babysitting).

D.

comment:11 @Denis-de-Bernardy8 years ago

lastly, in the text widget's title, if the title is empty, it is turned into a non-breaking space. this defeats the purpose of:

<?php !empty( $title ) ? print($before_title . $title . $after_title) : null; ?>

D.

comment:12 in reply to: ↑ 10 @rob1n8 years ago

Replying to Denis-de-Bernardy:

if you apply the filter 'the_content', you'll get plenty bugs with plugins along the lines of podpress. e.g. if the last post in the loop has media attached to it, each text widget will have a few media links.

Makes sense. I guess we can make the text widget its own filter.

also, the page exclude is heavily requested (at least among the users I'm babysitting).

Next thing I'm looking at :).

comment:13 @ryan8 years ago

autop and texturize are breaking the Google Reader Clip snippet. script tags are peed on and the script src is texturized. Since text widgets are commonly used for such snippets, we need to make sure we don't break them.

comment:14 @rob1n8 years ago

Which brings me back to my original proposal for making texturize/autop a checkbox :).

comment:15 @ryan8 years ago

Ideally, it should just work.

comment:16 @rob1n8 years ago

(In [5509]) Don't show title if user leaves it blank. see #4259

comment:17 @ryan8 years ago

(In [5517]) Remove the_content filter from widget text. see #4259

comment:18 @ryan8 years ago

(In [5518]) Remove the_content filter from widget text. see #4259

comment:19 @ryan8 years ago

Some plugins append things to the_content making it unsuitable for widget use. We can add a widget_text or generic text_content filter. I'd like to get autop and texturize playing nicely first.

comment:20 @rob1n8 years ago

(In [5519]) Run it through the filter. see #4259

@rob1n8 years ago

option to exclude pages

comment:21 @rob1n8 years ago

(In [5605]) Add option to exclude pages to pages widget. see #4259

comment:22 @rob1n8 years ago

  • Description modified (diff)
Note: See TracTickets for help on using tickets.