Problem: alignment of image with caption

[slilley]

Using Twenty-Ten them, if you put an image in a post, give it a caption and align it "none", the image should remain default-left aligned, with a small frame, and no text wrap.

After WP 4.9, that same image will now appear centered in the post, with a frame (and caption) that extends the full width of the post.

[slilley]

display, pre-WP4.9

[slilley]

display within WP4.9

[hardeepasrani]

I think I found the issue in the theme, but I'm just wondering if the Twenty Ten theme is still being maintained?

[slilley]

Replying to hardeepasrani:

I think I found the issue in the theme, but I'm just wondering if the Twenty Ten theme is still being maintained?

Yes, Twenty Ten theme has been updated.

[Clorith]

Introduced in r41724

The use of max-width on the container lets the wp-caption-text cause it to overflow for some reason, providing a max-width that mimics the parents max width might be an idea (so far only observed on themes that do not have HTML5 support, so it might be something there)

[slilley]

Even if the caption is short (i.e. narrower than the image), the shaded frame still goes wide.

Replying to Clorith:

Introduced in r41724

The use of max-width on the container lets the wp-caption-text cause it to overflow for some reason, providing a max-width that mimics the parents max width might be an idea (so far only observed on themes that do not have HTML5 support, so it might be something there)

[obenland]

In 42386:

Twenty Ten: Use global img contraint for captions

Fixes an incompatibility with the way caption width is set since 4.9, where the caption element would cover the whole content width.

Props slilley, Clorith, hardeepasrani.
Fixes #42604.

[slilley]

I still see the same problem on my end. Not fixed yet.

[obenland]

@slilley Do you have a public test site that I can access with the fix not working. Does it still occur for anyone else?

[Clorith]

Patch is good on my end.

Just a note for those still experiencing this issue, this is prepared for version 4.9.2, which has not been released yet, so you won't see any change unless you are using the beta tester plugin or any other method of testing the new release.

[dd32]

Bumping to 4.9.3 due to 4.9.2s release

[slilley]

Replying to obenland:

@slilley Do you have a public test site that I can access with the fix not working. Does it still occur for anyone else?

Sure — here's an example on a page from my site:
​http://recklesslistening.com/2010/03/26/greeting-card-emergency/

I'm running WP 4.9.2, and using a child theme of Twenty-Ten 2.4. And I still get the problem even when I switch from my child theme into straight Twenty-Ten 2.4.

[obenland]

Yeah, your version of Twenty Ten doesn't have [42386] applied, it still forcibly sets the caption width to the full content width. Once that's updated, it'll be fixed.

[SergeyBiryukov]

Moving to 5.0, as bundled themes are generally updated with major releases.

[portpass1974]

Is there a fix for this yet? It's still causing the captions to be "justified". See at ​http://rogerannis.com/austerity-militaristic-government-budget-canada/.

[SergeyBiryukov]

Given that we're going to include #43317 in 4.9.5, reopening this one for a backport as well. See #43572.

[SergeyBiryukov]

Looks like this needs some more work:

• .wp-caption img { max-width: 622px; /* caption width - 10px */ } is a remnant of the line removed in [42386].
• .wp-caption still needs a max-width, as full-sized images with a caption break the layout now, see 42604.full-size.PNG​.
• editor-style.css should be updated as well.

[SergeyBiryukov]

[41724] was reverted in [42838], which will ship in 4.9.5, returning the caption shortcode to the pre-4.9.0 behavior.

Seems like reverting [42386] would be the way to go for trunk, no changes are needed for the 4.9 branch.

[SergeyBiryukov]

In 42886:

Twenty Ten: Restore max-width on .wp-caption.

[42837] fixed the compatibility issue caused by [41724], returning the caption shortcode to the pre-4.9.0 behavior.

Reverts [42386].
Fixes #42604.