Opened 8 years ago
Closed 8 years ago
#42611 closed defect (bug) (duplicate)
Validate get_post_templates() File Cache
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Priority: | normal | |
| Severity: | normal | Version: | 4.9 |
| Component: | General | Keywords: | |
| Focuses: | administration | Cc: |
Description
The WP_Theme Class method get_files() caches the all the theme's files. Whenever anything calls WP_Theme->get_post_templates() it pulls from the transient but whenever looping through the file it does not verify the cached file exists before calling `file_get_content()`. I suggest we change LNL1048 to the following:
if ( ! ( file_exists( $full_path ) && preg_match( '|Template Name:(.*)$|mi', file_get_contents( $full_path ), $header ) ) ) {
continue;
}
If a file is removed within the hour cache limit, Pages Post Templates throw out some errors.
Attachments (1)
Change History (2)
Note: See
TracTickets for help on using
tickets.
WP_Theme Post Template Errors