Changes between Initial Version and Version 1 of Ticket #42643, comment 21
- Timestamp:
- 01/13/2018 12:16:45 PM (8 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #42643, comment 21
initial v1 3 3 1. I get 139 js errors: {{{flv.min.js:6 [TransmuxingController] > DemuxException: type = CodecUnsupported, info = Flv: Unsupported codec in video frame: 2}}}, no matter if the patch [attachment:42643.3.patch] is applied or not. Maybe it's just my test install? 4 4 2. Would it be possible to use e.g. {{{media.rendererName.match( /(flv|flash)/i )}}} (returns null or array) instead of multiple {{{indexOf()}}} like: {{{-1 !== media.rendererName.indexOf( 'flash' ) || -1 !== media.rendererName.indexOf( 'flv' )}}} ? 5 3. Shouldn't we have the ''Download'' string translatable? So in my language (Icelandic) I would see e.g.{{{<a href="http://test.localhost/wp-content/uploads/2018/01/small.flv?_=1">Sækja small.flv?_=1</a>}}} 5 3. Shouldn't we have the ''Download'' string translatable? So in my language (Icelandic) I would see e.g.{{{<a href="http://test.localhost/wp-content/uploads/2018/01/small.flv?_=1">Sækja small.flv?_=1</a>}}}. Maybe one could even reuse the {{{'mejs.download-video'}}} string from {{{mejsL10n}}} in {{{/wp-includes/script-loader.php}}} ? 6 6 4. Should we remove the {{{?_=1}}} in the link text, e.g. {{{<a href="http://test.localhost/wp-content/uploads/2018/01/small.flv?_=1">Download small.flv</a>}}}, since the extra {{{?_=1}}} might be confusing to the user and since the downloaded file is also without it: {{{small.flv}}}?