WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#42647 closed defect (bug) (fixed)

Underline links in the plugin description for installed plugins

Reported by: Travel_girl Owned by: afercia
Milestone: 5.1 Priority: normal
Severity: normal Version:
Component: Plugins Keywords: has-screenshots has-patch
Focuses: ui, accessibility Cc:

Description

At the moment the links in the plugin description for installed plugins are not underlined.

In my eyes this is fine for the lower links like "details", "support" and so on because there are separated with "|" and stand alone. But I see a problem for links in the plugin description above, cause color blind people could miss the links in the text.

I would suggest to underline the links in the plugin excerption so its easier for everyone to spot the links.

.plugin-description a {

text-decoration: underline;

}

Attachments (10)

Bildschirmfoto 2017-11-20 um 23.27.00.png (361.4 KB) - added by Travel_girl 4 years ago.
Current view
Bildschirmfoto 2017-11-20 um 23.27.00 Kopie.png (289.2 KB) - added by Travel_girl 4 years ago.
Current view in black and white
Bildschirmfoto 2017-11-20 um 23.28.31.png (375.9 KB) - added by Travel_girl 4 years ago.
links underlined
Bildschirmfoto 2017-11-20 um 23.28.31 Kopie.png (298.8 KB) - added by Travel_girl 4 years ago.
links underlined in black and white
42647.diff (129.1 KB) - added by chetan200891 4 years ago.
Created patch for link underline in plugin description.
42647.1.diff (696 bytes) - added by chetan200891 4 years ago.
Added latest patch 426471.1.diff
42647.2.diff (698 bytes) - added by chetan200891 4 years ago.
Added space before "{".
426471.3.diff (1.5 KB) - added by chetan200891 4 years ago.
Created patch for link underline on plugin update notice and dashboard of updates.
42647.4.patch (477 bytes) - added by Shital Patel 4 years ago.
added class in common.css ".plugin-version-author-uri a, .plugin-update p a, .plugin-title p a"
42647.3.diff (464 bytes) - added by afercia 4 years ago.

Download all attachments as: .zip

Change History (24)

@Travel_girl
4 years ago

Current view in black and white

@Travel_girl
4 years ago

links underlined in black and white

#1 @Travel_girl
4 years ago

  • Keywords needs-patch has-screenshots added

@chetan200891
4 years ago

Created patch for link underline in plugin description.

#3 @chetan200891
4 years ago

  • Keywords has-patch added; needs-patch removed

@Travel_girl +1

I have attached patch 42647.diff

There was already class ".plugins .desc p" so I have used it and added CSS "plugins .desc p a" for make underline of links in plugin description.

@chetan200891
4 years ago

Added latest patch 426471.1.diff

#4 @chetan200891
4 years ago

Sorry. I am new to core contribution. Added wrong 426471.diff which has other patches also included. So I have added latest patch 426471.1.diff

@chetan200891
4 years ago

Added space before "{".

#5 @afercia
4 years ago

Should the links within the update notices be underlined too? I guess so, as the contrast on the yellow background is even lower than on a white background.

Plugins page:

https://cldup.com/rcwz99_Tnu.png

On the Dashboard the background is white but there's no underline:

https://cldup.com/TtGiJcV1rY.png

This would also improve consistency with similar links used for Themes, that are underlined:

https://cldup.com/ly0tl_Ckrv.png

@chetan200891
4 years ago

Created patch for link underline on plugin update notice and dashboard of updates.

#6 @chetan200891
4 years ago

I have created patch 426471.3.diff for link underline on plugin update notice and dashboard of updates. Suggested by @afercia

#7 @Travel_girl
4 years ago

@chetan200891 thanks for the patches and welcome to contributing! :-)

@afercia yes there should be underlined too because it is also surrounded by p, so color blind people could miss the links.

@Shital Patel
4 years ago

added class in common.css ".plugin-version-author-uri a, .plugin-update p a, .plugin-title p a"

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


4 years ago

#9 @afercia
4 years ago

  • Component changed from General to Plugins
  • Milestone changed from Awaiting Review to 5.0

This ticket was mentioned in Slack in #design by melchoyce. View the logs.


4 years ago

@afercia
4 years ago

#11 @afercia
4 years ago

42647.3.diff refreshes the patch. As mentioned in the original ticket description, better to not touch the links in the line below the plugins description because they're separated with "|" and the context helps clarifying they're links.

See in the screenshot below an example of the links that are going to be underlined (plus the one in the Updates screen):

https://cldup.com/SpUzCHRyBU.png

#12 @afercia
4 years ago

  • Owner set to afercia
  • Resolution set to fixed
  • Status changed from new to closed

In 42810:

Accessibility: Underline the links in the Plugins descriptions and update notices.

Links within blocks and lines of text should always be underlined.

Props Travel_girl, chetan200891, Shital Patel.
Fixes #42647.

This ticket was mentioned in Slack in #core by chetan200891. View the logs.


4 years ago

#14 @johnbillion
3 years ago

  • Milestone changed from 5.0 to 5.1
Note: See TracTickets for help on using tickets.