WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#42648 closed defect (bug) (wontfix)

Some buttons have become rounded in the Customizer (Chrome).

Reported by: taskotr Owned by:
Milestone: Priority: normal
Severity: trivial Version:
Component: Customize Keywords: has-patch close
Focuses: Cc:

Description

After Chrome update to version 62.0.3202.94 (Official Build) (64-bit), some buttons (Device buttons and Back button) have become rounded in the Customizer.

Defining a border radius in these buttons fixes the problem:

.customize-panel-back, 
.customize-section-back,
.wp-full-overlay-footer .devices button {
  border-radius: 0;
}

Attachments (2)

customizer_rounded_buttons.jpg (52.4 KB) - added by taskotr 2 years ago.
42648.diff (1.7 KB) - added by chetan200891 2 years ago.
Created patch for remove border-radius.

Download all attachments as: .zip

Change History (11)

@chetan200891
2 years ago

Created patch for remove border-radius.

#1 @chetan200891
2 years ago

  • Keywords has-patch added

@taskotr

I have checked and noticed same thing in chrome. So I have created patch 42648.diff

#2 @swissspidy
2 years ago

Yeah it‘s a chrome feature in the newest version. All buttons are getting a border radius by default on macOS.

#3 follow-up: @afercia
2 years ago

Worth noting seems the Chrome team decided to revert this "feature" in the next version. See https://bugs.chromium.org/p/chromium/issues/detail?id=752450#c13

#4 in reply to: ↑ 3 @chetan200891
2 years ago

Replying to afercia:

Worth noting seems the Chrome team decided to revert this "feature" in the next version. See https://bugs.chromium.org/p/chromium/issues/detail?id=752450#c13

Sounds good!

#5 @johnbillion
2 years ago

  • Keywords close added
  • Severity changed from normal to trivial
  • Version 4.9 deleted

Seeing as this change affects only Chrome Canary and will be reverted long before WordPress 5.0 is released, I think it's safe to close this as a wontfix.

#6 @johnbillion
2 years ago

Apologies, Chrome 62 is stable.

We could fix this in 4.9.1, or not worry about it.

#7 @melchoyce
2 years ago

Let's see if this is reverted in Chrome by the time we have a 4.9.1 release date in mind. I wonder if it's worth adding in an explicit lack of border radius just in case something like this happens again :/

#8 @westonruter
2 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

It looks like Chrome 63 will be released early December, so probably a month before 4.9.1. Given they explicitly are undoing the border radius, I highly doubt they'd re-introduce it.

This ticket was mentioned in Slack in #core-committers by johnbillion. View the logs.


2 years ago

Note: See TracTickets for help on using tickets.