WordPress.org

Make WordPress Core

Opened 21 months ago

Closed 19 months ago

Last modified 19 months ago

#42655 closed enhancement (fixed)

Customize: Consider using more-specific "locked" messages when branching is enabled

Reported by: dlh Owned by: westonruter
Milestone: 4.9.3 Priority: normal
Severity: normal Version: 4.9
Component: Customize Keywords: has-patch commit fixed-major i18n-change
Focuses: Cc:

Description

When changeset branching is enabled, users can be locked out of editing individual changesets instead of the whole Customizer.

However, the "locked" message when branching is enabled still refers to another user "customizing this site," potentially implying that the Customizer itself is inaccessible.

The attached patch would attempt to provide different "locked" messages when branching is enabled that limit the scope of what they tell the user.

Attachments (2)

42655.diff (2.2 KB) - added by dlh 21 months ago.
42655.2.diff (2.2 KB) - added by dlh 21 months ago.

Download all attachments as: .zip

Change History (13)

@dlh
21 months ago

#1 @westonruter
21 months ago

  • Milestone changed from Awaiting Review to 4.9.1

Good point.

#2 @westonruter
21 months ago

When in branching mode, would it be useful to have a button that opens the Customzier with a new changeset? That may be premature. Eventually there should maybe be a way to navigate to a list of all changesets to pick from.

@dlh
21 months ago

#3 @dlh
21 months ago

My initial reaction is also that a "Create" button might be premature. Plus, if I'm reading correctly, _admin_notice_post_locked() doesn't offer a button to go to the "Add New" screen, in which case adding one in the Customizer would create an inconsistency.

42655.2.diff reduces the variables into an array of strings so more can be added easily later.

#4 @johnbillion
21 months ago

  • Milestone changed from 4.9.1 to 4.9.2

This ticket was mentioned in Slack in #core-customize by westonruter. View the logs.


19 months ago

#6 @westonruter
19 months ago

  • Owner set to westonruter
  • Status changed from new to reviewing

#7 @dd32
19 months ago

  • Milestone changed from 4.9.2 to 4.9.3

Bumping to 4.9.3 due to 4.9.2s release

#8 @westonruter
19 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 42538:

Customize: Use changeset-specific "locked" messages when branching is enabled.

Props dlh.
See #39896.
Fixes #42655.

#9 @westonruter
19 months ago

  • Keywords commit fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

#10 @westonruter
19 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 42539:

Customize: Use changeset-specific "locked" messages when branching is enabled.

Props dlh.
See #39896.
Fixes #42655 for 4.9 branch.

#11 @ocean90
19 months ago

  • Keywords i18n-change added
Note: See TracTickets for help on using tickets.