WordPress.org

Make WordPress Core

Opened 8 weeks ago

Last modified 6 hours ago

#42658 reviewing defect (bug)

Customize: Heartbeat doesn't refresh changeset lock when branching is enabled

Reported by: dlh Owned by: westonruter
Milestone: 4.9.3 Priority: normal
Severity: normal Version: 4.9
Component: Customize Keywords: has-patch
Focuses: Cc:

Description

Heartbeat requests from the Customizer will create a WP_Customize_Manager instance without a changeset_uuid. However, when changeset branching is active and when the manager is instantiated without a UUID, WP_Customize_Manager::establish_loaded_changeset() will generate a new UUID.

Without the UUID from the client, WP_Customize_Manager::check_changeset_lock_with_heartbeat() won't have a post ID whose lock should be refreshed.

The attached patch would attempt to address this by including the current UUID with the heartbeat request. The patch then has check_changeset_lock_with_heartbeat() use the heartbeat UUID to find the changeset post ID before falling back to WP_Customize_Manager::changeset_post_id().

Attachments (1)

42658.diff (1.9 KB) - added by dlh 8 weeks ago.

Download all attachments as: .zip

Change History (6)

@dlh
8 weeks ago

#1 @westonruter
8 weeks ago

  • Milestone changed from Awaiting Review to 4.9.1

Good catch!

#2 @johnbillion
8 weeks ago

  • Milestone changed from 4.9.1 to 4.9.2

This ticket was mentioned in Slack in #core-customize by westonruter. View the logs.


33 hours ago

#4 @westonruter
33 hours ago

  • Owner set to westonruter
  • Status changed from new to reviewing

#5 @dd32
6 hours ago

  • Milestone changed from 4.9.2 to 4.9.3

Bumping to 4.9.3 due to 4.9.2s release

Note: See TracTickets for help on using tickets.